content/browser/renderer_host/media/video_capture_device_impl.h - Issue 140633004: Reland CL to implement browser-side logging to WebRtc log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_device_impl.h

Issue 140633004: Reland CL to implement browser-side logging to WebRtc log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: These are the changes that should fix crbug.com/338848 Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/media/video_capture_device_impl.h

diff --git a/content/browser/renderer_host/media/video_capture_device_impl.h b/content/browser/renderer_host/media/video_capture_device_impl.h

index 56bf1e0eac8dbd564f489de78df3146b33c01030..87d4c1930a260bf103f116e60446902fb764f2d4 100644

--- a/content/browser/renderer_host/media/video_capture_device_impl.h

+++ b/content/browser/renderer_host/media/video_capture_device_impl.h

@@ -71,7 +71,7 @@ class ThreadSafeCaptureOracle

void Stop();

// Signal an error to the client.

- void ReportError();

+ void ReportError(const std::string& reason);

private:

friend class base::RefCountedThreadSafe<ThreadSafeCaptureOracle>;

@@ -165,7 +165,7 @@ class CONTENT_EXPORT VideoCaptureDeviceImpl

void CaptureStarted(bool success);

// Stops capturing and notifies client_ of an error state.

- void Error();

+ void Error(const std::string& reason);

// Tracks that all activity occurs on the media stream manager's thread.

base::ThreadChecker thread_checker_;