Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1674)

Unified Diff: chrome/browser/media/webrtc_logging_handler_host.cc

Issue 140633004: Reland CL to implement browser-side logging to WebRtc log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: These are the changes that should fix crbug.com/338848 Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_logging_handler_host.cc
diff --git a/chrome/browser/media/webrtc_logging_handler_host.cc b/chrome/browser/media/webrtc_logging_handler_host.cc
index 611bc520ae000b0391379c2253f77e16db739441..31759bb679a642fd803384754989f1021ff65d25 100644
--- a/chrome/browser/media/webrtc_logging_handler_host.cc
+++ b/chrome/browser/media/webrtc_logging_handler_host.cc
@@ -203,6 +203,14 @@ void WebRtcLoggingHandlerHost::DiscardLog(const GenericDoneCallback& callback) {
FireGenericDoneCallback(&discard_callback, true, "");
}
+void WebRtcLoggingHandlerHost::LogMessage(const std::string& message) {
+ BrowserThread::PostTask(
+ BrowserThread::IO,
+ FROM_HERE,
+ base::Bind(
+ &WebRtcLoggingHandlerHost::AddLogMessageFromBrowser, this, message));
+}
+
void WebRtcLoggingHandlerHost::OnChannelClosing() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
if (logging_state_ == STARTED || logging_state_ == STOPPED) {
@@ -234,6 +242,13 @@ bool WebRtcLoggingHandlerHost::OnMessageReceived(const IPC::Message& message,
return handled;
}
+void WebRtcLoggingHandlerHost::AddLogMessageFromBrowser(
+ const std::string& message) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ if (logging_state_ == STARTED)
+ LogToCircularBuffer(message);
+}
+
void WebRtcLoggingHandlerHost::OnAddLogMessage(const std::string& message) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
if (logging_state_ == STARTED || logging_state_ == STOPPING)

Powered by Google App Engine
This is Rietveld 408576698