Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: content/browser/renderer_host/media/audio_input_renderer_host.cc

Issue 140633004: Reland CL to implement browser-side logging to WebRtc log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: These are the changes that should fix crbug.com/338848 Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_input_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.cc b/content/browser/renderer_host/media/audio_input_renderer_host.cc
index ec619449772146448c72bda106464411286ccb98..93ed16ce07f03a06818ef1c639eff604ba962498 100644
--- a/content/browser/renderer_host/media/audio_input_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_input_renderer_host.cc
@@ -176,6 +176,8 @@ void AudioInputRendererHost::DoSendRecordingMessage(
void AudioInputRendererHost::DoHandleError(
media::AudioInputController* controller) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ MediaStreamManager::SendMessageToNativeLog(
+ "The AudioInputController signalled an error.");
AudioEntry* entry = LookupByController(controller);
if (!entry)
@@ -310,6 +312,8 @@ void AudioInputRendererHost::OnCreateStream(
entry->stream_id = stream_id;
audio_entries_.insert(std::make_pair(stream_id, entry.release()));
+ MediaStreamManager::SendMessageToNativeLog(
+ "Audio input stream created successfully.");
audio_log_->OnCreated(stream_id, audio_params, device_id, std::string());
}
@@ -349,6 +353,8 @@ void AudioInputRendererHost::OnSetVolume(int stream_id, double volume) {
}
void AudioInputRendererHost::SendErrorMessage(int stream_id) {
+ MediaStreamManager::SendMessageToNativeLog(
+ "An error occurred in AudioInputRendererHost.");
Send(new AudioInputMsg_NotifyStreamStateChanged(
stream_id, media::AudioInputIPCDelegate::kError));
}

Powered by Google App Engine
This is Rietveld 408576698