Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140593005: add legacy/helper allocN32Pixels, and convert gm to use it (Closed)

Created:
6 years, 11 months ago by reed1
Modified:
6 years, 11 months ago
Reviewers:
hal.canary, scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add legacy/helper allocN32Pixels, and convert gm to use it This is an intermediate api, but might help us quickly get to a point where no one is creating bitmaps in a 2-step process (setConfig + alloc). BUG=skia: R=halcanary@google.com Committed: https://code.google.com/p/skia/source/detail?r=13182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -178 lines) Patch
M gm/aaclip.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/aarectmodes.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/arithmode.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/bicubicfilter.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M gm/bigmatrix.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/bitmapmatrix.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/bitmappremul.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/bitmaprect.cpp View 3 chunks +3 lines, -10 lines 0 comments Download
M gm/bitmaprecttest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/bitmapscroll.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/bitmapshader.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/bitmapsource.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/bleed.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/clippedbitmapshaders.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/colormatrix.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/deviceproperties.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/displacement.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/downsamplebitmap.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M gm/drawbitmaprect.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/extractbitmap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/filterbitmap.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M gm/giantbitmap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/gmmain.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/hairmodes.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/imagefiltersbase.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/imagefilterscropped.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/lighting.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/mixedxfermodes.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/modecolorfilters.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/morphology.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/ninepatchstretch.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/offsetimagefilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/optimizations.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/pathopsinverse.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/samplerstress.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M gm/scalebitmap.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/shadertext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/shadertext2.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/shadertext3.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/spritebitmap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/tablecolorfilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/tileimagefilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/tilemodes.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/verylargebitmap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/xfermodes.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/xfermodes2.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M gm/xfermodes3.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M include/core/SkBitmap.h View 1 chunk +15 lines, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
6 years, 11 months ago (2014-01-24 22:38:53 UTC) #1
hal.canary
lgtm
6 years, 11 months ago (2014-01-24 23:26:25 UTC) #2
reed1
6 years, 11 months ago (2014-01-25 16:46:42 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r13182 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698