Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting) (Closed)

Created:
5 years, 2 months ago by Xianzhu
Modified:
4 years, 6 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, sof, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(WIP) Invalidation during painting (for synchronized painting)

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : No more crash? #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -265 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/absolute-position-change-containing-block.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/absolute-position-moved.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/absolute-position-moved-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/fixed-and-absolute-position-scrolled.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-col-border-color.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/multi-subsequence-composited.html View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/spv2/cached-change-cell-border-color.html View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/spv2/cached-change-col-border-color.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/invalidate-after-composited-scroll-of-window-expected.txt View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/spv2/paint/selection/selection-within-composited-scroller-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/spv2/paint/invalidation/spv2/selection-within-composited-scroller-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 8 chunks +75 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +38 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +33 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/EmbeddedObjectPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FieldsetPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FileUploadControlPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FrameSetPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/HTMLCanvasPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlinePainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorderTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +12 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +26 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LineBoxListPainter.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +16 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGClipPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootInlineBoxPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ViewPainter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +55 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Xianzhu
Still WIP. Fighting with bugs, about fixed position, scrolling, carets, etc. I'm not sure how ...
5 years, 2 months ago (2015-10-08 22:20:32 UTC) #1
chrishtr
Is it looking harder than expected?
5 years, 2 months ago (2015-10-08 23:58:42 UTC) #3
Xianzhu
On 2015/10/08 23:58:42, chrishtr wrote: > Is it looking harder than expected? (Was on vacation ...
5 years, 2 months ago (2015-10-12 16:42:48 UTC) #4
Xianzhu
On 2015/10/12 16:42:48, Xianzhu wrote: > On 2015/10/08 23:58:42, chrishtr wrote: > > Is it ...
5 years, 2 months ago (2015-10-19 16:50:36 UTC) #5
Xianzhu
5 years, 2 months ago (2015-10-19 20:45:40 UTC) #7
Xianzhu
5 years, 2 months ago (2015-10-19 20:46:50 UTC) #8 
Added pdr@ to share the status.

Powered by Google App Engine
This is Rietveld 408576698