third_party/WebKit/Source/core/paint/ObjectPainter.cpp - Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPainter.cpp

Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp ('k') | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/ObjectPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/ObjectPainter.cpp b/third_party/WebKit/Source/core/paint/ObjectPainter.cpp

index 97a574bf943f6040042ad0ef58408c4418b47723..7d8bf00e5c60d032bbcde0e8a9cd50b7c6e76834 100644

--- a/third_party/WebKit/Source/core/paint/ObjectPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/ObjectPainter.cpp

@@ -203,7 +203,7 @@ void ObjectPainter::paintOutline(const PaintInfo& paintInfo, const LayoutPoint&

if (outlineRects.isEmpty())

return;

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutObject, paintInfo.phase, paintOffset))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutObject, paintInfo.phase))

return;

// The result rects are in coordinates of m_layoutObject's border box.

@@ -224,7 +224,7 @@ void ObjectPainter::paintOutline(const PaintInfo& paintInfo, const LayoutPoint&

IntRect unitedOutlineRect = unionRectEvenIfEmpty(pixelSnappedOutlineRects);

IntRect bounds = unitedOutlineRect;

bounds.inflate(m_layoutObject.styleRef().outlineOutsetExtent());

- LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutObject, paintInfo.phase, bounds, paintOffset);

+ LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutObject, paintInfo.phase, bounds);

Color color = m_layoutObject.resolveColor(styleToUse, CSSPropertyOutlineColor);

if (styleToUse.outlineStyleIsAuto()) {

@@ -266,10 +266,10 @@ void ObjectPainter::addPDFURLRectIfNeeded(const PaintInfo& paintInfo, const Layo

if (rect.isEmpty())

return;

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutObject, DisplayItem::PrintedContentPDFURLRect, paintOffset))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutObject, DisplayItem::PrintedContentPDFURLRect))

return;

- LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutObject, DisplayItem::PrintedContentPDFURLRect, rect, paintOffset);

+ LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutObject, DisplayItem::PrintedContentPDFURLRect, rect);

if (url.hasFragmentIdentifier() && equalIgnoringFragmentIdentifier(url, m_layoutObject.document().baseURL())) {

String fragmentName = url.fragmentIdentifier();

if (m_layoutObject.document().findAnchor(fragmentName))