third_party/WebKit/Source/core/paint/PartPainter.cpp - Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PartPainter.cpp

Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h ('k') | third_party/WebKit/Source/core/paint/ReplacedPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PartPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/PartPainter.cpp b/third_party/WebKit/Source/core/paint/PartPainter.cpp

index 8af5a805d73b993ac02b39b64fca785e4c395103..c28a10d02c7992f4ada58e735fa2af7d94249517 100644

--- a/third_party/WebKit/Source/core/paint/PartPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/PartPainter.cpp

@@ -42,10 +42,10 @@ bool PartPainter::isSelected() const

void PartPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)

{

- LayoutPoint adjustedPaintOffset = paintOffset + m_layoutPart.location();

- if (!ReplacedPainter(m_layoutPart).shouldPaint(paintInfo, adjustedPaintOffset))

+ if (!ReplacedPainter(m_layoutPart).shouldPaint(paintInfo, paintOffset))

return;

+ LayoutPoint adjustedPaintOffset = paintOffset + m_layoutPart.location();

LayoutRect borderRect(adjustedPaintOffset, m_layoutPart.size());

if (m_layoutPart.hasBoxDecorationBackground() && (paintInfo.phase == PaintPhaseForeground || paintInfo.phase == PaintPhaseSelection))

@@ -83,11 +83,11 @@ void PartPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOffs

}

// Paint a partially transparent wash over selected widgets.

- if (isSelected() && !paintInfo.isPrinting() && !LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutPart, paintInfo.phase, adjustedPaintOffset)) {

+ if (isSelected() && !paintInfo.isPrinting() && !LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutPart, paintInfo.phase)) {

LayoutRect rect = m_layoutPart.localSelectionRect();

rect.moveBy(adjustedPaintOffset);

IntRect selectionRect = pixelSnappedIntRect(rect);

- LayoutObjectDrawingRecorder drawingRecorder(paintInfo.context, m_layoutPart, paintInfo.phase, selectionRect, adjustedPaintOffset);

+ LayoutObjectDrawingRecorder drawingRecorder(paintInfo.context, m_layoutPart, paintInfo.phase, selectionRect);

paintInfo.context.fillRect(selectionRect, m_layoutPart.selectionBackgroundColor());

}