third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp - Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp

Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxPainter.cpp ('k') | third_party/WebKit/Source/core/paint/EmbeddedObjectPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp b/third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp

index b731eae14c584f2139a3c2887539ec1f14df7cf5..a296edd9e6e602616149f8dc8baaf2e0ac666229 100644

--- a/third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp

@@ -20,17 +20,18 @@ void DetailsMarkerPainter::paint(const PaintInfo& paintInfo, const LayoutPoint&

return;

}

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutDetailsMarker, paintInfo.phase, paintOffset))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutDetailsMarker, paintInfo.phase))

return;

- LayoutPoint boxOrigin(paintOffset + m_layoutDetailsMarker.location());

+ LayoutPoint adjustedPaintOffset = paintOffset + m_layoutDetailsMarker.location();

+ LayoutPoint boxOrigin(adjustedPaintOffset);

LayoutRect overflowRect(m_layoutDetailsMarker.visualOverflowRect());

overflowRect.moveBy(boxOrigin);

if (!paintInfo.cullRect().intersectsCullRect(overflowRect))

return;

- LayoutObjectDrawingRecorder layoutDrawingRecorder(paintInfo.context, m_layoutDetailsMarker, paintInfo.phase, overflowRect, paintOffset);

+ LayoutObjectDrawingRecorder layoutDrawingRecorder(paintInfo.context, m_layoutDetailsMarker, paintInfo.phase, overflowRect);

const Color color(m_layoutDetailsMarker.resolveColor(CSSPropertyColor));

paintInfo.context.setFillColor(color);