Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
index fab3dbc0d5ac2fe7f2cf90f625a513b3f589e50c..30611e73a316e67495f8974141bb7d9e117b723d 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
@@ -43,7 +43,7 @@ public:
// These methods are called during paint invalidation (or paint if SlimmingPaintV2 is on).
- void invalidate(const DisplayItemClient&);
+ void invalidate(const DisplayItemClient&, PaintInvalidationReason, const IntRect& previousPaintInvalidationRect, const IntRect& newPaintInvalidationRect);
void invalidateUntracked(const DisplayItemClient&);
void invalidateAll();
@@ -264,10 +264,17 @@ private:
unsigned m_nextScope;
Vector<unsigned> m_scopeStack;
-#if ENABLE(ASSERT)
+ struct Invalidation {
+ DisplayItemClient client;
+ String debugName;
+ IntRect rect;
+ PaintInvalidationReason invalidationReason;
+ };
+
// Record the debug names of invalidated clients for assertion and debugging.
- Vector<String> m_invalidations;
+ Vector<Invalidation> m_invalidations;
+#if ENABLE(ASSERT)
// This is used to check duplicated ids during add(). We could also check
// during commitNewDisplayItems(), but checking during add() helps developer
// easily find where the duplicated ids are from.
@@ -275,6 +282,8 @@ private:
#endif
OwnPtr<Vector<String>> m_trackedPaintInvalidationObjects;
+public:
+ String m_debugName;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698