third_party/WebKit/Source/core/paint/FieldsetPainter.cpp - Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FieldsetPainter.cpp

Issue 1391753005: (WIP) Invalidation during painting (for synchronized painting) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/EmbeddedObjectPainter.cpp ('k') | third_party/WebKit/Source/core/paint/FileUploadControlPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FieldsetPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/FieldsetPainter.cpp b/third_party/WebKit/Source/core/paint/FieldsetPainter.cpp

index bd800348676e096c20e3f3eb8a0a3850fd31ffac..7790d91f6fd3db8e05a96f6f69f11ad10e18d7da 100644

--- a/third_party/WebKit/Source/core/paint/FieldsetPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/FieldsetPainter.cpp

@@ -20,7 +20,7 @@ void FieldsetPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo, c

if (!legend)

return BoxPainter(m_layoutFieldset).paintBoxDecorationBackground(paintInfo, paintOffset);

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutFieldset, paintInfo.phase, paintOffset))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutFieldset, paintInfo.phase))

return;

// FIXME: We need to work with "rl" and "bt" block flow directions. In those

@@ -36,7 +36,7 @@ void FieldsetPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo, c

paintRect.setX(paintRect.x() + xOff);

}

- LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutFieldset, paintInfo.phase, paintRect, paintOffset);

+ LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutFieldset, paintInfo.phase, paintRect);

BoxDecorationData boxDecorationData(m_layoutFieldset);

if (boxDecorationData.bleedAvoidance == BackgroundBleedNone)

@@ -77,7 +77,7 @@ void FieldsetPainter::paintMask(const PaintInfo& paintInfo, const LayoutPoint& p

if (!legend)

return BoxPainter(m_layoutFieldset).paintMask(paintInfo, paintOffset);

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutFieldset, paintInfo.phase, paintOffset))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutFieldset, paintInfo.phase))

return;

// FIXME: We need to work with "rl" and "bt" block flow directions. In those

@@ -93,7 +93,7 @@ void FieldsetPainter::paintMask(const PaintInfo& paintInfo, const LayoutPoint& p

paintRect.move(xOff, LayoutUnit());

}

- LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutFieldset, paintInfo.phase, paintRect, paintOffset);

+ LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutFieldset, paintInfo.phase, paintRect);

BoxPainter(m_layoutFieldset).paintMaskImages(paintInfo, paintRect);

}