Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/ (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
Reviewers:
Finnur, agl
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/ This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=finnur@chromium.org,agl@chromium.org Committed: https://crrev.com/a21ed8c892e49fd2ceebc9890d01f488111978cc Cr-Commit-Position: refs/heads/master@{#353545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M extensions/browser/api/alarms/alarms_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_icon_image_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/file_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/image_loader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/value_store/value_store_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/test/extension_test_message_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_test_channel_listener.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_test_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
ki.stfu
5 years, 2 months ago (2015-10-10 08:22:46 UTC) #1
ki.stfu
finnur@: please review extensions/ jeremy@: please review ipc/
5 years, 2 months ago (2015-10-10 08:29:22 UTC) #2
jeremy
On 2015/10/10 08:29:22, ki.stfu wrote: > finnur@: please review extensions/ > jeremy@: please review ipc/ ...
5 years, 2 months ago (2015-10-11 07:08:29 UTC) #3
ki.stfu
On 2015/10/11 07:08:29, jeremy wrote: > On 2015/10/10 08:29:22, ki.stfu wrote: > > finnur@: please ...
5 years, 2 months ago (2015-10-11 20:16:27 UTC) #5
Finnur
extension tests LGTM
5 years, 2 months ago (2015-10-12 13:32:43 UTC) #6
agl
lgtm
5 years, 2 months ago (2015-10-12 16:29:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389163008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389163008/1
5 years, 2 months ago (2015-10-12 16:45:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 17:26:14 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 17:27:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a21ed8c892e49fd2ceebc9890d01f488111978cc
Cr-Commit-Position: refs/heads/master@{#353545}

Powered by Google App Engine
This is Rietveld 408576698