ipc/ipc_test_sink.h - Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_test_sink.h

Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_test_sink.h

diff --git a/ipc/ipc_test_sink.h b/ipc/ipc_test_sink.h

index 5539c98d7cbd1574bade41f752cb5d02daa733dc..d964498de15da6f2913af0e93c7caac6b12183b7 100644

--- a/ipc/ipc_test_sink.h

+++ b/ipc/ipc_test_sink.h

@@ -59,7 +59,7 @@ class Message;

// public:

// virtual bool OnMessageReceived(const IPC::Message& msg) {

// <do something with the message>

-// MessageLoop::current()->Quit();

+// MessageLoop::current()->QuitWhenIdle();

// return false; // to store the message in the sink, or true to drop it

// }

// };

« no previous file with comments | « ipc/ipc_test_channel_listener.cc ('k') | ipc/mojo/ipc_channel_mojo_unittest.cc » ('j') | no next file with comments »