Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: ipc/ipc_channel_posix_unittest.cc

Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/test/extension_test_message_listener.cc ('k') | ipc/ipc_fuzzing_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_posix_unittest.cc
diff --git a/ipc/ipc_channel_posix_unittest.cc b/ipc/ipc_channel_posix_unittest.cc
index 99bd68b5e3fc36f7de54c46bc80eab6f82528eaf..5dc4de46ef394367660f963e29b50de821adf975 100644
--- a/ipc/ipc_channel_posix_unittest.cc
+++ b/ipc/ipc_channel_posix_unittest.cc
@@ -89,7 +89,7 @@ class IPCChannelPosixTestListener : public IPC::Listener {
loop->QuitNow();
} else {
// Die as soon as Run is called.
- loop->task_runner()->PostTask(FROM_HERE, loop->QuitClosure());
+ loop->task_runner()->PostTask(FROM_HERE, loop->QuitWhenIdleClosure());
}
}
@@ -189,7 +189,8 @@ void IPCChannelPosixTest::SpinRunLoop(base::TimeDelta delay) {
// in the case of a bad test. Usually, the run loop will quit sooner than
// that because all tests use a IPCChannelPosixTestListener which quits the
// current run loop on any channel activity.
- loop->task_runner()->PostDelayedTask(FROM_HERE, loop->QuitClosure(), delay);
+ loop->task_runner()->PostDelayedTask(FROM_HERE, loop->QuitWhenIdleClosure(),
+ delay);
loop->Run();
}
« no previous file with comments | « extensions/test/extension_test_message_listener.cc ('k') | ipc/ipc_fuzzing_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698