ipc/ipc_send_fds_test.cc - Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_send_fds_test.cc

Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_send_fds_test.cc

diff --git a/ipc/ipc_send_fds_test.cc b/ipc/ipc_send_fds_test.cc

index 22965da2d232c8d5240d44245ef861ba2088aeac..a3b4d4e86de39eaa2b00a3fe79a3332c274623ad 100644

--- a/ipc/ipc_send_fds_test.cc

+++ b/ipc/ipc_send_fds_test.cc

@@ -73,7 +73,7 @@ class MyChannelDescriptorListener : public MyChannelDescriptorListenerBase {

}

void OnChannelError() override {

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

protected:

@@ -96,7 +96,7 @@ class MyChannelDescriptorListener : public MyChannelDescriptorListenerBase {

++num_fds_received_;

if (num_fds_received_ == kNumFDsToSend * kNumMessages)

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

private:

« no previous file with comments | « ipc/ipc_fuzzing_tests.cc ('k') | ipc/ipc_test_channel_listener.cc » ('j') | no next file with comments »