extensions/shell/browser/shell_desktop_controller_aura.cc - Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_desktop_controller_aura.cc

Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/value_store/value_store_frontend_unittest.cc ('k') | extensions/test/extension_test_message_listener.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/browser/shell_desktop_controller_aura.cc

diff --git a/extensions/shell/browser/shell_desktop_controller_aura.cc b/extensions/shell/browser/shell_desktop_controller_aura.cc

index f89714a391996a1f3280c26bb3d66b80dea6d08a..2cf78efd0a31b7e2ad205528223ad4485179de1a 100644

--- a/extensions/shell/browser/shell_desktop_controller_aura.cc

+++ b/extensions/shell/browser/shell_desktop_controller_aura.cc

@@ -246,8 +246,8 @@ void ShellDesktopControllerAura::OnHostCloseRequested(

const aura::WindowTreeHost* host) {

DCHECK_EQ(host_.get(), host);

CloseAppWindows();

- base::MessageLoop::current()->PostTask(FROM_HERE,

- base::MessageLoop::QuitClosure());

+ base::MessageLoop::current()->PostTask(

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

}

void ShellDesktopControllerAura::InitWindowManager() {