extensions/browser/api/alarms/alarms_api_unittest.cc - Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/alarms/alarms_api_unittest.cc

Issue 1389163008: Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/alarms/alarms_api_unittest.cc

diff --git a/extensions/browser/api/alarms/alarms_api_unittest.cc b/extensions/browser/api/alarms/alarms_api_unittest.cc

index 61a469b83fb16cd5ac384d7048bdc3b123c791ab..b08eed39c4fd9a97a4ced671fdc313687fbd090f 100644

--- a/extensions/browser/api/alarms/alarms_api_unittest.cc

+++ b/extensions/browser/api/alarms/alarms_api_unittest.cc

@@ -32,7 +32,7 @@ class AlarmDelegate : public AlarmManager::Delegate {

void OnAlarm(const std::string& extension_id, const Alarm& alarm) override {

alarms_seen.push_back(alarm.js_alarm->name);

if (base::MessageLoop::current()->is_running())

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

std::vector<std::string> alarms_seen;

« no previous file with comments | « no previous file | extensions/browser/api_test_utils.cc » ('j') | no next file with comments »