Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1365073002: Revert of Remove register index/code indirection (Closed)

Created:
5 years, 3 months ago by danno
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove register index/code indirection (patchset #17 id:320001 of https://codereview.chromium.org/1287383003/ ) Reason for revert: Failures on greedy RegAlloc, Fuzzer Original issue's description: > Remove register index/code indirection > > Previous to this patch, both the lithium and TurboFan register > allocators tracked allocated registers by "indices", rather than > the register codes used elsewhere in the runtime. This patch > ensures that codes are used everywhere, and in the process cleans > up a bunch of redundant code and adds more structure to how the > set of allocatable registers is defined. > > Some highlights of changes: > > * TurboFan's RegisterConfiguration class moved to V8's top level > so that it can be shared with Crankshaft. > * Various "ToAllocationIndex" and related methods removed. > * Code that can be easily shared between Register classes on > different platforms is now shared. > * The list of allocatable registers on each platform is declared > as a list rather than implicitly via the register index <-> > code mapping. > > Committed: https://crrev.com/80bc6f6e11f79524e3f1ad05579583adfd5f18b2 > Cr-Commit-Position: refs/heads/master@{#30913} TBR=akos.palfi@imgtec.com,bmeurer@chromium.org,jarin@chromium.org,paul.lind@imgtec.com,titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3ac27431a9e960fd4aee483fa05f5ecb90b13691 Cr-Commit-Position: refs/heads/master@{#30914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1859 lines, -1670 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/assembler-arm.h View 6 chunks +154 lines, -112 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +26 lines, -14 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +43 lines, -1 line 0 comments Download
M src/arm/constants-arm.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +14 lines, -14 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/assembler-arm64.h View 10 chunks +130 lines, -54 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/arm64/constants-arm64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/utils-arm64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M src/compiler/c-linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/code-generator-impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/instruction.h View 2 chunks +1 line, -16 lines 0 comments Download
M src/compiler/instruction.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 3 chunks +10 lines, -5 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/register-allocator.h View 6 chunks +5 lines, -14 lines 0 comments Download
M src/compiler/register-allocator.cc View 17 chunks +32 lines, -71 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 chunk +2 lines, -4 lines 0 comments Download
A src/compiler/register-configuration.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/compiler/register-configuration.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/frames.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +122 lines, -95 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +7 lines, -9 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 6 chunks +13 lines, -17 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.cc View 7 chunks +17 lines, -24 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +11 lines, -11 lines 0 comments Download
M src/lithium.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M src/lithium-allocator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/lithium-allocator.cc View 14 chunks +46 lines, -51 lines 0 comments Download
M src/mips/assembler-mips.h View 6 chunks +187 lines, -130 lines 0 comments Download
M src/mips/assembler-mips.cc View 8 chunks +53 lines, -31 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +30 lines, -0 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 5 chunks +12 lines, -16 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +10 lines, -10 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M src/mips64/assembler-mips64.h View 5 chunks +185 lines, -128 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 8 chunks +53 lines, -31 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +30 lines, -0 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 5 chunks +12 lines, -16 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +11 lines, -11 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 4 chunks +4 lines, -7 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/register-configuration.h View 1 chunk +0 lines, -88 lines 0 comments Download
D src/register-configuration.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +182 lines, -142 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +7 lines, -9 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 6 chunks +11 lines, -14 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +11 lines, -11 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 4 chunks +7 lines, -13 lines 0 comments Download
M src/x87/assembler-x87.h View 2 chunks +16 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 17 chunks +53 lines, -94 lines 0 comments Download
M test/cctest/test-code-stubs-arm.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M test/cctest/test-code-stubs-arm64.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M test/cctest/test-code-stubs-ia32.cc View 2 chunks +10 lines, -14 lines 0 comments Download
M test/cctest/test-code-stubs-mips.cc View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 2 chunks +1 line, -3 lines 0 comments Download
M test/cctest/test-code-stubs-x64.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danno
Created Revert of Remove register index/code indirection
5 years, 3 months ago (2015-09-24 13:38:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1365073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1365073002/1
5 years, 3 months ago (2015-09-24 13:38:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 13:39:01 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 13:39:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ac27431a9e960fd4aee483fa05f5ecb90b13691
Cr-Commit-Position: refs/heads/master@{#30914}

Powered by Google App Engine
This is Rietveld 408576698