test/unittests/compiler/instruction-selector-unittest.cc - Issue 1365073002: Revert of Remove register index/code indirection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/instruction-selector-unittest.cc

Issue 1365073002: Revert of Remove register index/code indirection (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/instruction-selector-unittest.cc

diff --git a/test/unittests/compiler/instruction-selector-unittest.cc b/test/unittests/compiler/instruction-selector-unittest.cc

index 76bfe2217183f1b2a270c290f6bf1d73bc910fda..e14382e914a214378c81a5f52a3886ba4ee3f798 100644

--- a/test/unittests/compiler/instruction-selector-unittest.cc

+++ b/test/unittests/compiler/instruction-selector-unittest.cc

@@ -127,7 +127,8 @@

if (!operand->IsUnallocated()) return false;

const UnallocatedOperand* unallocated = UnallocatedOperand::cast(operand);

if (!unallocated->HasFixedRegisterPolicy()) return false;

- return unallocated->fixed_register_index() == reg.code();

+ const int index = Register::ToAllocationIndex(reg);

+ return unallocated->fixed_register_index() == index;

}