Only (and always) put URLs in NSLinkAttributeName.

Only (and always) put URLs in NSLinkAttributeName.

When the NSLinkAttributeName attribute is used, AppKit automatically turns it into a draggable link. If anything but a URL is used, that link then becomes a bomb to explode drag targets. This change ensures that only URLs are put in there, and that a URL is always put in there.

BUG=528228
TEST=existing tests

Committed: https://crrev.com/7c0b59d9c9dfba08fe924dd0ee219ec94b65bb87
Cr-Commit-Position: refs/heads/master@{#351805}

[Avi (use Gerrit), 2015-09-23 23:11:48]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 23:13:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364113003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364113003/1

[Avi (use Gerrit), 2015-09-23 23:15:50]

avi@chromium.org changed reviewers:
+ pinkerton@chromium.org

[Avi (use Gerrit), 2015-09-23 23:15:51]

Pink, I don't know who would be a good reviewer here. You commented on the list,
so I'm tossing it to you; I won't mind if you hand it off.

This has a dependency on the infobar delegate being able to vend a URL. That's
in a different CL (https://codereview.chromium.org/1361253002), and pkasting
seems OK with it.

The problem is with all the other uses. These links are used everywhere for
things that Are Not Links. I got all pissy in the comments, but I'm not sure how
much better we can do things.

[commit-bot: I haz the power, 2015-09-24 00:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 00:14:51]

Dry run: This issue passed the CQ dry run.

[noyau (Ping after 24h), 2015-09-24 07:54:05]

noyau@chromium.org changed reviewers:
+ noyau@chromium.org

[noyau (Ping after 24h), 2015-09-24 07:54:05]

https://codereview.chromium.org/1364113003/diff/1/ui/base/cocoa/controls/hype...
File ui/base/cocoa/controls/hyperlink_text_view.h (right):

https://codereview.chromium.org/1364113003/diff/1/ui/base/cocoa/controls/hype...
ui/base/cocoa/controls/hyperlink_text_view.h:31: withURL:(NSString*)url
Driving by: Is there a reason why this is a string? If you expect a URL wouldn't
it better to just type it as a GURL here?

[vabr (Chromium), 2015-09-24 08:47:16]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-09-24 08:47:17]

Thanks for fixing the drag&drop problem, LGTM for passwords files. I filed
http://crbug.com/535458 for our team to check why we use the empty URLs.

Cheers,
Vaclav

[pink (ping after 24hrs), 2015-09-24 11:07:21]

pinkerton@chromium.org changed reviewers:
+ andresantoso@chromium.org, erikchen@chromium.org

[pink (ping after 24hrs), 2015-09-24 11:07:22]

+erik and andre, one of these two can help.

[Avi (use Gerrit), 2015-09-24 14:24:57]

https://codereview.chromium.org/1364113003/diff/1/ui/base/cocoa/controls/hype...
File ui/base/cocoa/controls/hyperlink_text_view.h (right):

https://codereview.chromium.org/1364113003/diff/1/ui/base/cocoa/controls/hype...
ui/base/cocoa/controls/hyperlink_text_view.h:31: withURL:(NSString*)url
On 2015/09/24 07:54:05, noyau wrote:
> Driving by: Is there a reason why this is a string? If you expect a URL
wouldn't
> it better to just type it as a GURL here?

This is a core Cocoa UI class, and everything else is taken in Cocoa types, so
I'm doing that here too. If I were to change to any URL class, it would be
NSURL*.

[Andre, 2015-09-24 16:28:48]

LGTM

[Avi (use Gerrit), 2015-09-30 23:54:49]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-30 23:56:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364113003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364113003/20001

[Avi (use Gerrit), 2015-09-30 23:57:38]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-30 23:58:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364113003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364113003/40001

[commit-bot: I haz the power, 2015-10-01 00:05:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 00:05:12]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Avi (use Gerrit), 2015-10-01 14:54:50]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2015-10-01 14:54:51]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
andresantoso@chromium.org
Link to the patchset: https://codereview.chromium.org/1364113003/#ps40001
(title: "stray deletion")

[commit-bot: I haz the power, 2015-10-01 14:55:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364113003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364113003/40001

[commit-bot: I haz the power, 2015-10-01 15:12:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-01 15:13:20]

Patchset 3 (id:??) landed as
https://crrev.com/7c0b59d9c9dfba08fe924dd0ee219ec94b65bb87
Cr-Commit-Position: refs/heads/master@{#351805}