chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm - Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm

Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobar1

Patch Set: stray deletion Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm ('k') | chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm

index e58996d7ab42068c9ea725bfefd15fdd4ac965c3..4021743cc250f2f81059410567e4feb5fd32a606 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm

@@ -92,7 +92,7 @@ const int kFontSize = 11;

withFont:font

messageColor:gfx::SkColorToDeviceNSColor(kTextColor)];

[textView_ addLinkRange:NSMakeRange(offset, [nsLinkText length])

- withName:@""

+ withURL:@"about:blank" // using a link here is bad ui

linkColor:linkColor];

[textView_ setRefusesFirstResponder:YES];

[[textView_ textContainer] setLineFragmentPadding:0.0];