chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm - Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm

Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobar1

Patch Set: stray deletion Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm

index 6d68353840d803a863a4127552b0e80f4fc7986e..197f3df1f18f97bdd6ac85498796bf7ec64edfe7 100644

--- a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm

+++ b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm

@@ -244,7 +244,7 @@ const float kHideDuration = 0.7;

messageColor:[NSColor blackColor]];

if ([exitLinkText length] != 0) {

[exitLabel_.get() addLinkRange:NSMakeRange(0, [exitLinkText length])

- withName:@""

+ withURL:@"about:blank" // using link here is bad ui

linkColor:[NSColor blueColor]];

}

[exitLabel_.get() setAlignment:NSRightTextAlignment];