chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm - Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm

Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobar1

Patch Set: stray deletion Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm

index 93590e30af1990ac0c2c141009ec1559e0a99c67..0246250ce0bd50ba3483b3912e50608d57f27a4e 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm

@@ -86,11 +86,11 @@

withFont:[NSFont labelFontOfSize:[[textview_ font] pointSize]]

messageColor:textColor];

if (!notification->link_range().is_empty()) {

+ linkURL_ = notification->link_url();

[textview_ setDelegate:self];

[textview_ addLinkRange:notification->link_range().ToNSRange()

- withName:self

+ withURL:base::SysUTF8ToNSString(linkURL_.spec())

linkColor:[NSColor blueColor]];

- linkURL_ = notification->link_url();

}

tooltipController_.reset([[AutofillTooltipController alloc]

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm » ('j') | no next file with comments »