chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobar1

Patch Set: stray deletion Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm ('k') | chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 4789f2928f0d8da74dc38595160453ee421faa21..a5466bfecd6fea3b343a64f5dd81953c3b9e795d 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -372,7 +372,7 @@ bool ExtensionInstalledBubbleBridge::MaybeShowNow() {

HyperlinkTextView* view = promo_.get();

[view setMessage:message withFont:font messageColor:[NSColor blackColor]];

[view addLinkRange:NSMakeRange(0, [link length])

- withName:@""

+ withURL:@"about:blank" // using a link here is bad ui

linkColor:gfx::SkColorToCalibratedNSColor(

chrome_style::GetLinkColor())];