chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm - Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm

Issue 1364113003: Only (and always) put URLs in NSLinkAttributeName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@infobar1

Patch Set: stray deletion Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm ('k') | ui/base/cocoa/controls/hyperlink_text_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm b/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm

index 857881ddb6f9a89316459f16a3feb233b7a936fe..ca7441484961e8ddb25513fd3faa1e36f024da03 100644

--- a/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm

+++ b/chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.mm

@@ -180,7 +180,7 @@ static const CGFloat kMaxTopMargin = 130;

withFont:helpFont

messageColor:[message_ textColor]];

[help_ addLinkRange:NSMakeRange(linkOffset, helpLink.length())

- withName:@(chrome::kCrashReasonURL)

+ withURL:@(chrome::kCrashReasonURL)

linkColor:[message_ textColor]];

[help_ setAlignment:NSLeftTextAlignment];

[help_ sizeToFit];