Only (and always) put URLs in NSLinkAttributeName.

ui/base/cocoa/controls/hyperlink_text_view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "ui/base/ui_base_export.h"
 
 @class NSColor;
 
 // HyperlinkTextView is an NSTextView subclass for unselectable, linkable text.
 // This subclass doesn't show the text caret or IBeamCursor, whereas the base
 // class NSTextView displays both with full keyboard accessibility enabled.
 UI_BASE_EXPORT
 @interface HyperlinkTextView : NSTextView {
  @private
   BOOL refusesFirstResponder_;
   BOOL drawsBackgroundUsingSuperview_;
 }
 
 @property(nonatomic, assign) BOOL drawsBackgroundUsingSuperview;
 
 // Set the |message| displayed by the HyperlinkTextView, using |font| and
 // |messageColor|.
 - (void)setMessage:(NSString*)message
           withFont:(NSFont*)font
       messageColor:(NSColor*)messageColor;
 
-// Marks a |range| within the given message as link, associating it with
-// a |name| that is passed to the delegate's textView:clickedOnLink:atIndex:.
+// Marks a |range| within the given message as link.
 - (void)addLinkRange:(NSRange)range
-            withName:(id)name
+             withURL:(NSString*)url

[noyau (Ping after 24h), 2015/09/24 07:54:05]

Driving by: Is there a reason why this is a string? If you expect a URL wouldn't
it better to just type it as a GURL here?

[Avi (use Gerrit), 2015/09/24 14:24:57]

This is a core Cocoa UI class, and everything else is taken in Cocoa types, so
I'm doing that here too. If I were to change to any URL class, it would be
NSURL*.

            linkColor:(NSColor*)linkColor;
 
 // This is NO (by default) if the view rejects first responder status.
 - (void)setRefusesFirstResponder:(BOOL)refusesFirstResponder;
 
 @end