Implement IIRFilter node for WebAudio.

Implement IIRFilter node for WebAudio.

A general IIRFilterNode is implemented here.

The WebAudio bug and discussion is https://github.com/WebAudio/web-audio-api/issues/323.

The spec is http://webaudio.github.io/web-audio-api/#the-iirfilternode-interface

BUG=514782
TEST=iirfilter.html, iirfilter-basic.html, iirfilter-getFrequencyResponse.html

Committed: https://crrev.com/98d09f13ad251f35173a57c8fab10a8cfe11b479
Cr-Commit-Position: refs/heads/master@{#369641}

[Raymond Toy, 2015-09-29 22:14:53]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[hongchan, 2015-10-09 18:10:00]

I strongly suggest to run the layout test with '--enable-leak-detection' option
before we move forward.

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/AudioContext.idl (right):

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/AudioContext.idl:95: // IIR Filter
Can we have this line under the biquad? Or you want to keep them in the
chronological order?

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/AudioNode.cpp (right):

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/AudioNode.cpp:415: //
TODO(rtoy,hongchan): we special case the convolver, delay, biquad, and IIR since
they
'we special case...' - perhaps typo? It's not from this CL, but we can fix this
while we're at this.

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp (right):

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp:42: // This is true
mathematically (infinite impulse response), but perhaps it should be limited to
The comment sounds like a TODO, and it needs to be addressed later. So let's
make this 'TODO' for us.

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h (right):

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:28: void
getFrequencyResponse(const DOMFloat32Array* frequencyHz, DOMFloat32Array*
magResponse, DOMFloat32Array* phaseResponse, ExceptionState&);
It seems like we're passing DOMFloat32Array to the IIRDSPKernel, which isn't
Oilpan covered. Have you tried to run layout test with "--dump-render-tree
--enable-leak-detection" option? I am purely speculating, but it is easy to test
just to make sure.

[Raymond Toy, 2015-10-09 19:21:11]

On 2015/10/09 at 18:10:00, hongchan wrote:
> I strongly suggest to run the layout test with '--enable-leak-detection'
option before we move forward.

Ran run-webkit-tests --enable-leak-detection --repeat=10 webaudio/iirfilter*

No issues.

> 
>
https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
> File third_party/WebKit/Source/modules/webaudio/AudioContext.idl (right):
> 
>
https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
> third_party/WebKit/Source/modules/webaudio/AudioContext.idl:95: // IIR Filter
> Can we have this line under the biquad? Or you want to keep them in the
chronological order?
> 
>
https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
> File third_party/WebKit/Source/modules/webaudio/AudioNode.cpp (right):
> 
>
https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
> third_party/WebKit/Source/modules/webaudio/AudioNode.cpp:415: //
TODO(rtoy,hongchan): we special case the convolver, delay, biquad, and IIR since
they
> 'we special case...' - perhaps typo? It's not from this CL, but we can fix
this while we're at this.
> 
>
https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
> File third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp (right):
> 
>
https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
> third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp:42: // This is
true mathematically (infinite impulse response), but perhaps it should be
limited to
> The comment sounds like a TODO, and it needs to be addressed later. So let's
make this 'TODO' for us.
> 
>
https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
> File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h (right):
> 
>
https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
> third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:28: void
getFrequencyResponse(const DOMFloat32Array* frequencyHz, DOMFloat32Array*
magResponse, DOMFloat32Array* phaseResponse, ExceptionState&);
> It seems like we're passing DOMFloat32Array to the IIRDSPKernel, which isn't
Oilpan covered. Have you tried to run layout test with "--dump-render-tree
--enable-leak-detection" option? I am purely speculating, but it is easy to test
just to make sure.

[Raymond Toy, 2015-10-09 19:41:15]

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/AudioContext.idl (right):

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/AudioContext.idl:95: // IIR Filter
On 2015/10/09 at 18:10:00, hoch wrote:
> Can we have this line under the biquad? Or you want to keep them in the
chronological order?

Done.

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/AudioNode.cpp (right):

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/AudioNode.cpp:415: //
TODO(rtoy,hongchan): we special case the convolver, delay, biquad, and IIR since
they
On 2015/10/09 at 18:10:00, hoch wrote:
> 'we special case...' - perhaps typo? It's not from this CL, but we can fix
this while we're at this.

Done.  (I think.)

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp (right):

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp:42: // This is true
mathematically (infinite impulse response), but perhaps it should be limited to
On 2015/10/09 at 18:10:00, hoch wrote:
> The comment sounds like a TODO, and it needs to be addressed later. So let's
make this 'TODO' for us.

Done.

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h (right):

https://chromiumcodereview.appspot.com/1361233004/diff/40001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:28: void
getFrequencyResponse(const DOMFloat32Array* frequencyHz, DOMFloat32Array*
magResponse, DOMFloat32Array* phaseResponse, ExceptionState&);
On 2015/10/09 at 18:10:00, hoch wrote:
> It seems like we're passing DOMFloat32Array to the IIRDSPKernel, which isn't
Oilpan covered. Have you tried to run layout test with "--dump-render-tree
--enable-leak-detection" option? I am purely speculating, but it is easy to test
just to make sure.

Ran all of the iirfilter tests with --enable-leak-detection --repeat=10.  No
issues found.

[hongchan, 2015-10-12 22:55:56]

LGTM with nits.

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
File third_party/WebKit/LayoutTests/webaudio/iirfilter-getFrequencyResponse.html
(right):

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
third_party/WebKit/LayoutTests/webaudio/iirfilter-getFrequencyResponse.html:123:
runTest();
Can the content of runTest() be inside of this task?

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
File third_party/WebKit/LayoutTests/webaudio/iirfilter.html (right):

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
third_party/WebKit/LayoutTests/webaudio/iirfilter.html:88:
.beCloseToArray(iir1Data, 2.1958e-38) && success;
Why 2.1958e-38, not zero? I know it is fairly small to ignore, but why don't we
leave a note on the reason behind it? 

If you can describe this difference in decibel, it will be a bit more useful.

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
third_party/WebKit/LayoutTests/webaudio/iirfilter.html:158: Should('IIR 1-pole
output', actual).beCloseToArray(expected, 5.88e-39);
The same question: why 5.88e-39? Just a short note would suffice.

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp (right):

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp:42: m_feedback[k] /=
scale;
How did this line pass the presubmit check? It's one-line for-loop with curly
braces.

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
File third_party/WebKit/Source/platform/audio/IIRFilter.cpp (right):

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
third_party/WebKit/Source/platform/audio/IIRFilter.cpp:86: static
std::complex<double> polyEval(const float* coef, std::complex<double> z, int
order)
This method just pops up from nowhere. Can we move this static function to the
bottom or the top? Although it's obvious it might be better to expand the name a
bit.

[Raymond Toy, 2015-10-16 17:04:14]

Currently holding off uploading any changes pending the resolution of
https://github.com/WebAudio/web-audio-api/issues/631 which makes the
coefficients be doubles and not floats.

[Raymond Toy, 2015-10-29 17:10:00]

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
File third_party/WebKit/LayoutTests/webaudio/iirfilter-getFrequencyResponse.html
(right):

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
third_party/WebKit/LayoutTests/webaudio/iirfilter-getFrequencyResponse.html:123:
runTest();
On 2015/10/12 22:55:56, hoch wrote:
> Can the content of runTest() be inside of this task?

Done.

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
File third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp (right):

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp:42: m_feedback[k] /=
scale;
On 2015/10/12 22:55:56, hoch wrote:
> How did this line pass the presubmit check? It's one-line for-loop with curly
> braces.

Done.  And fixed the following loop too.

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
File third_party/WebKit/Source/platform/audio/IIRFilter.cpp (right):

https://chromiumcodereview.appspot.com/1361233004/diff/50001/third_party/WebK...
third_party/WebKit/Source/platform/audio/IIRFilter.cpp:86: static
std::complex<double> polyEval(const float* coef, std::complex<double> z, int
order)
On 2015/10/12 22:55:56, hoch wrote:
> This method just pops up from nowhere. Can we move this static function to the
> bottom or the top? Although it's obvious it might be better to expand the name
a
> bit.

Renamed to evaluatePolynomial and moved to the top.

[Raymond Toy, 2016-01-12 17:12:38]

rtoy@chromium.org changed reviewers:
+ haraken@chromium.org

[Raymond Toy, 2016-01-12 17:12:38]

PTAL for oilpan issues.

[haraken, 2016-01-13 02:42:15]

haraken@chromium.org changed reviewers:
+ tkent@chromium.org

[haraken, 2016-01-13 02:42:15]

The oilpan part LGTM.

The IDL change needs to be reviewed by an API owner.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.h (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.h:1: // Copyright 2015
The Chromium Authors. All rights reserved.

2016

[tkent, 2016-01-13 03:28:29]

Web-exposed change LGTM.  We have the approved intent-to-ship thread.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
(right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:564: if
(!feedbackCoef.size() || (feedbackCoef.size() > IIRFilter::kMaxOrder + 1)) {
nit: You may compare with 0 like |feedbackCoef.size() == 0| for integers.
https://www.chromium.org/blink/coding-style#TOC-Null-false-and-0

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:577: if
(!feedforwardCoef.size() || (feedforwardCoef.size() > IIRFilter::kMaxOrder + 1))
{
Ditto.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:590: if
(!feedbackCoef[0]) {
Ditto.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:600: if
(feedforwardCoef[k]) {
Ditto.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioContext.idl (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioContext.idl:97: 
nit: This line is unnecessary.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp:1: // Copyright 2015
The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp:54: } // blink
nit: blink -> namespace blink

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.h (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.h:39: } // blink
nit:  blink -> namespace blink

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp:1: // Copyright
2015 The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:1: // Copyright 2015
The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:11: #include
"wtf/build_config.h"
Probably wtf/build_config.h is unnecessary.  This file doesn't use macros
defined in it.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.idl (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.idl:1: // Copyright
2014 The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp:1: // Copyright 2015
The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp:26:
ASSERT(feedbackCoef[0]);
nit: You may compare with 0.  ASSERT(feedbackCoef[0] != 0);

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRProcessor.h (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.h:1: // Copyright 2015
The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.h:33: private:
nit: Add a blank line before |private:|.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.h:41: } // blink
nit: blink -> namespace blink

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/audio/IIRFilter.cpp (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/audio/IIRFilter.cpp:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/audio/IIRFilter.cpp:8: 
A blink line is unnecessary.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/audio/IIRFilter.cpp:45: result = result * z +
static_cast<std::complex<double>>(coef[k]);
Do we need static_cast<> here?
I think |result * z + std::complex<double>(ceof[k])| works.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/audio/IIRFilter.h (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/audio/IIRFilter.h:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/audio/IIRFilter.h:56: } // blink
nit: blink -> namespace blink

[Raymond Toy, 2016-01-13 18:30:54]

Thanks for the reviews!

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
(right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:564: if
(!feedbackCoef.size() || (feedbackCoef.size() > IIRFilter::kMaxOrder + 1)) {
On 2016/01/13 03:28:28, tkent wrote:
> nit: You may compare with 0 like |feedbackCoef.size() == 0| for integers.
> https://www.chromium.org/blink/coding-style#TOC-Null-false-and-0
> 

Ah, this seems to have changed from the original webkit style. I always hated
that, so thanks for pointing that out!

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:577: if
(!feedforwardCoef.size() || (feedforwardCoef.size() > IIRFilter::kMaxOrder + 1))
{
On 2016/01/13 03:28:28, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:590: if
(!feedbackCoef[0]) {
On 2016/01/13 03:28:28, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp:600: if
(feedforwardCoef[k]) {
On 2016/01/13 03:28:28, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioContext.idl (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioContext.idl:97: 
On 2016/01/13 03:28:28, tkent wrote:
> nit: This line is unnecessary.

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp:1: // Copyright 2015
The Chromium Authors. All rights reserved.
On 2016/01/13 03:28:28, tkent wrote:
> 2016

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp:54: } // blink
On 2016/01/13 03:28:28, tkent wrote:
> nit: blink -> namespace blink

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.h (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.h:1: // Copyright 2015
The Chromium Authors. All rights reserved.
On 2016/01/13 02:42:15, haraken wrote:
> 
> 2016

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.h:39: } // blink
On 2016/01/13 03:28:28, tkent wrote:
> nit:  blink -> namespace blink

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp:1: // Copyright
2015 The Chromium Authors. All rights reserved.
On 2016/01/13 03:28:28, tkent wrote:
> 2016

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:1: // Copyright 2015
The Chromium Authors. All rights reserved.
On 2016/01/13 03:28:28, tkent wrote:
> 2016

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.h:11: #include
"wtf/build_config.h"
On 2016/01/13 03:28:28, tkent wrote:
> Probably wtf/build_config.h is unnecessary.  This file doesn't use macros
> defined in it.

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRFilterNode.idl (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRFilterNode.idl:1: // Copyright
2014 The Chromium Authors. All rights reserved.
On 2016/01/13 03:28:28, tkent wrote:
> 2016

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp:1: // Copyright 2015
The Chromium Authors. All rights reserved.
On 2016/01/13 03:28:28, tkent wrote:
> 2016

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp:26:
ASSERT(feedbackCoef[0]);
On 2016/01/13 03:28:28, tkent wrote:
> nit: You may compare with 0.  ASSERT(feedbackCoef[0] != 0);

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/IIRProcessor.h (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.h:1: // Copyright 2015
The Chromium Authors. All rights reserved.
On 2016/01/13 03:28:28, tkent wrote:
> 2016

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.h:33: private:
On 2016/01/13 03:28:28, tkent wrote:
> nit: Add a blank line before |private:|.

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/IIRProcessor.h:41: } // blink
On 2016/01/13 03:28:28, tkent wrote:
> nit: blink -> namespace blink

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/audio/IIRFilter.cpp (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/audio/IIRFilter.cpp:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/01/13 03:28:28, tkent wrote:
> 2016

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/audio/IIRFilter.cpp:8: 
On 2016/01/13 03:28:28, tkent wrote:
> A blink line is unnecessary.

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/audio/IIRFilter.cpp:45: result = result * z +
static_cast<std::complex<double>>(coef[k]);
On 2016/01/13 03:28:28, tkent wrote:
> Do we need static_cast<> here?
> I think |result * z + std::complex<double>(ceof[k])| works.

Done.

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/audio/IIRFilter.h (right):

https://codereview.chromium.org/1361233004/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/audio/IIRFilter.h:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/01/13 03:28:29, tkent wrote:
> 2016

Done.

[Raymond Toy, 2016-01-13 18:34:27]

rtoy@chromium.org changed reviewers:
+ isherman@chromium.org

[Raymond Toy, 2016-01-13 18:34:27]

isherman@ PTAL at histograms.xml

[Ilya Sherman, 2016-01-13 19:50:16]

histograms.xml lgtm

[Raymond Toy, 2016-01-13 21:08:38]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-01-13 21:08:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org, tkent@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1361233004/#ps290001
(title: "Rebase and address review comments")

[commit-bot: I haz the power, 2016-01-13 21:09:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361233004/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361233004/290001

[commit-bot: I haz the power, 2016-01-13 23:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 23:13:51]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[Raymond Toy, 2016-01-14 18:17:00]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-01-14 18:17:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org, isherman@chromium.org, hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1361233004/#ps310001
(title: "Fix typo")

[commit-bot: I haz the power, 2016-01-14 18:17:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361233004/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361233004/310001

[commit-bot: I haz the power, 2016-01-14 18:21:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 18:21:18]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raymond Toy, 2016-01-14 19:15:11]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-01-14 19:15:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org, isherman@chromium.org, hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1361233004/#ps330001
(title: "Rebase for UseCounter.h")

[commit-bot: I haz the power, 2016-01-14 19:15:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361233004/330001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361233004/330001

[commit-bot: I haz the power, 2016-01-14 21:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 21:17:03]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raymond Toy, 2016-01-14 22:09:07]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-01-14 22:09:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org, isherman@chromium.org, hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1361233004/#ps350001
(title: "Fix test issue by printing fewer digits.")

[commit-bot: I haz the power, 2016-01-14 22:10:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361233004/350001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361233004/350001

[commit-bot: I haz the power, 2016-01-15 01:09:40]

Committed patchset #19 (id:350001)

[commit-bot: I haz the power, 2016-01-15 01:10:26]

Description was changed from

==========
Implement IIRFilter node for WebAudio.

A general IIRFilterNode is implemented here.

The WebAudio bug and discussion is
https://github.com/WebAudio/web-audio-api/issues/323.

The spec is http://webaudio.github.io/web-audio-api/#the-iirfilternode-interface

BUG=514782
TEST=iirfilter.html, iirfilter-basic.html, iirfilter-getFrequencyResponse.html
==========

to

==========
Implement IIRFilter node for WebAudio.

A general IIRFilterNode is implemented here.

The WebAudio bug and discussion is
https://github.com/WebAudio/web-audio-api/issues/323.

The spec is http://webaudio.github.io/web-audio-api/#the-iirfilternode-interface

BUG=514782
TEST=iirfilter.html, iirfilter-basic.html, iirfilter-getFrequencyResponse.html

Committed: https://crrev.com/98d09f13ad251f35173a57c8fab10a8cfe11b479
Cr-Commit-Position: refs/heads/master@{#369641}
==========

[commit-bot: I haz the power, 2016-01-15 01:10:27]

Patchset 19 (id:??) landed as
https://crrev.com/98d09f13ad251f35173a57c8fab10a8cfe11b479
Cr-Commit-Position: refs/heads/master@{#369641}