Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/. (Closed)

Created:
5 years, 2 months ago by Avi (use Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
blundell
CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark functions overriding Blink with "override" in components/test_runner/. BUG=535367 TEST=it all stays working Committed: https://crrev.com/0e223566bea33877c155253738b28803687e0bdb Cr-Commit-Position: refs/heads/master@{#351091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -171 lines) Patch
M components/test_runner/app_banner_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/mock_color_chooser.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/test_runner/mock_credential_manager_client.h View 1 chunk +6 lines, -7 lines 0 comments Download
M components/test_runner/mock_screen_orientation_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/test_runner/mock_web_audio_device.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/test_runner/mock_web_media_stream_center.h View 1 chunk +16 lines, -16 lines 0 comments Download
M components/test_runner/mock_web_media_stream_center.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/test_runner/mock_web_midi_accessor.h View 1 chunk +6 lines, -6 lines 0 comments Download
M components/test_runner/mock_web_speech_recognizer.h View 1 chunk +8 lines, -8 lines 0 comments Download
M components/test_runner/mock_web_user_media_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M components/test_runner/mock_webrtc_data_channel_handler.h View 1 chunk +14 lines, -16 lines 0 comments Download
M components/test_runner/mock_webrtc_dtmf_sender_handler.h View 1 chunk +6 lines, -6 lines 0 comments Download
M components/test_runner/mock_webrtc_peer_connection_handler.h View 1 chunk +26 lines, -34 lines 0 comments Download
M components/test_runner/spell_check_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M components/test_runner/test_plugin.h View 1 chunk +32 lines, -33 lines 0 comments Download
M components/test_runner/web_content_settings.h View 1 chunk +14 lines, -14 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360123005/1
5 years, 2 months ago (2015-09-25 21:04:33 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-25 22:10:06 UTC) #4
Avi (use Gerrit)
5 years, 2 months ago (2015-09-26 01:36:06 UTC) #6
Avi (use Gerrit)
Adam is out for two days; Colin, can you take this?
5 years, 2 months ago (2015-09-28 15:58:37 UTC) #8
blundell
lgtm
5 years, 2 months ago (2015-09-28 18:16:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360123005/1
5 years, 2 months ago (2015-09-28 18:20:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 19:02:59 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:05:31 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0e223566bea33877c155253738b28803687e0bdb
Cr-Commit-Position: refs/heads/master@{#351091}

Powered by Google App Engine
This is Rietveld 408576698