Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: components/test_runner/spell_check_client.h

Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/mock_webrtc_peer_connection_handler.h ('k') | components/test_runner/test_plugin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/spell_check_client.h
diff --git a/components/test_runner/spell_check_client.h b/components/test_runner/spell_check_client.h
index d96afce4d3e2dd607a24dc7c80265972df18f346..04a705eafd0242e3e63b186bb1c4646d2a9bc630 100644
--- a/components/test_runner/spell_check_client.h
+++ b/components/test_runner/spell_check_client.h
@@ -26,21 +26,21 @@ class SpellCheckClient : public blink::WebSpellCheckClient {
MockSpellCheck* MockSpellCheckWord() { return &spell_check_; }
// blink::WebSpellCheckClient implementation.
- virtual void spellCheck(
+ void spellCheck(
const blink::WebString& text,
int& offset,
int& length,
- blink::WebVector<blink::WebString>* optional_suggestions);
- virtual void checkTextOfParagraph(
+ blink::WebVector<blink::WebString>* optional_suggestions) override;
+ void checkTextOfParagraph(
const blink::WebString& text,
blink::WebTextCheckingTypeMask mask,
- blink::WebVector<blink::WebTextCheckingResult>* web_results);
- virtual void requestCheckingOfText(
+ blink::WebVector<blink::WebTextCheckingResult>* web_results) override;
+ void requestCheckingOfText(
const blink::WebString& text,
const blink::WebVector<uint32_t>& markers,
const blink::WebVector<unsigned>& marker_offsets,
- blink::WebTextCheckingCompletion* completion);
- virtual blink::WebString autoCorrectWord(const blink::WebString& word);
+ blink::WebTextCheckingCompletion* completion) override;
+ blink::WebString autoCorrectWord(const blink::WebString& word) override;
private:
void FinishLastTextCheck();
« no previous file with comments | « components/test_runner/mock_webrtc_peer_connection_handler.h ('k') | components/test_runner/test_plugin.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698