components/test_runner/app_banner_client.h - Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/app_banner_client.h

Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/app_banner_client.h

diff --git a/components/test_runner/app_banner_client.h b/components/test_runner/app_banner_client.h

index 1ecd77c4e4be53a11f6300debd67185536cdad13..b268c9f1011152c00995736236b4b39ab22e88ef 100644

--- a/components/test_runner/app_banner_client.h

+++ b/components/test_runner/app_banner_client.h

@@ -18,7 +18,7 @@ class TEST_RUNNER_EXPORT AppBannerClient

: public NON_EXPORTED_BASE(blink::WebAppBannerClient) {

public:

AppBannerClient();

- virtual ~AppBannerClient();

+ ~AppBannerClient() override;

// blink::WebAppBannerClient:

void registerBannerCallbacks(

« no previous file with comments | « no previous file | components/test_runner/mock_color_chooser.h » ('j') | no next file with comments »