Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: components/test_runner/mock_webrtc_peer_connection_handler.h

Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/mock_webrtc_peer_connection_handler.h
diff --git a/components/test_runner/mock_webrtc_peer_connection_handler.h b/components/test_runner/mock_webrtc_peer_connection_handler.h
index 3470e1ba561e665ffaf2fe74047b18ce6268cd68..c828f428fbfa7c002c71e5f4f1afc12715c9b3ca 100644
--- a/components/test_runner/mock_webrtc_peer_connection_handler.h
+++ b/components/test_runner/mock_webrtc_peer_connection_handler.h
@@ -28,49 +28,41 @@ class MockWebRTCPeerConnectionHandler
MockWebRTCPeerConnectionHandler(
blink::WebRTCPeerConnectionHandlerClient* client,
TestInterfaces* interfaces);
- virtual ~MockWebRTCPeerConnectionHandler();
+ ~MockWebRTCPeerConnectionHandler() override;
// WebRTCPeerConnectionHandler related methods
- virtual bool initialize(
- const blink::WebRTCConfiguration& configuration,
- const blink::WebMediaConstraints& constraints) override;
-
- virtual void createOffer(
- const blink::WebRTCSessionDescriptionRequest& request,
- const blink::WebMediaConstraints& constraints) override;
- virtual void createOffer(
- const blink::WebRTCSessionDescriptionRequest& request,
- const blink::WebRTCOfferOptions& options) override;
- virtual void createAnswer(
- const blink::WebRTCSessionDescriptionRequest& request,
- const blink::WebMediaConstraints& constraints) override;
- virtual void setLocalDescription(
+ bool initialize(const blink::WebRTCConfiguration& configuration,
+ const blink::WebMediaConstraints& constraints) override;
+
+ void createOffer(const blink::WebRTCSessionDescriptionRequest& request,
+ const blink::WebMediaConstraints& constraints) override;
+ void createOffer(const blink::WebRTCSessionDescriptionRequest& request,
+ const blink::WebRTCOfferOptions& options) override;
+ void createAnswer(const blink::WebRTCSessionDescriptionRequest& request,
+ const blink::WebMediaConstraints& constraints) override;
+ void setLocalDescription(
const blink::WebRTCVoidRequest& request,
const blink::WebRTCSessionDescription& local_description) override;
- virtual void setRemoteDescription(
+ void setRemoteDescription(
const blink::WebRTCVoidRequest& request,
const blink::WebRTCSessionDescription& remote_description) override;
- virtual blink::WebRTCSessionDescription localDescription() override;
- virtual blink::WebRTCSessionDescription remoteDescription() override;
- virtual bool updateICE(
- const blink::WebRTCConfiguration& configuration,
- const blink::WebMediaConstraints& constraints) override;
- virtual bool addICECandidate(
- const blink::WebRTCICECandidate& ice_candidate) override;
- virtual bool addICECandidate(
- const blink::WebRTCVoidRequest& request,
- const blink::WebRTCICECandidate& ice_candidate) override;
- virtual bool addStream(
- const blink::WebMediaStream& stream,
- const blink::WebMediaConstraints& constraints) override;
- virtual void removeStream(const blink::WebMediaStream& stream) override;
- virtual void getStats(const blink::WebRTCStatsRequest& request) override;
- virtual blink::WebRTCDataChannelHandler* createDataChannel(
+ blink::WebRTCSessionDescription localDescription() override;
+ blink::WebRTCSessionDescription remoteDescription() override;
+ bool updateICE(const blink::WebRTCConfiguration& configuration,
+ const blink::WebMediaConstraints& constraints) override;
+ bool addICECandidate(const blink::WebRTCICECandidate& ice_candidate) override;
+ bool addICECandidate(const blink::WebRTCVoidRequest& request,
+ const blink::WebRTCICECandidate& ice_candidate) override;
+ bool addStream(const blink::WebMediaStream& stream,
+ const blink::WebMediaConstraints& constraints) override;
+ void removeStream(const blink::WebMediaStream& stream) override;
+ void getStats(const blink::WebRTCStatsRequest& request) override;
+ blink::WebRTCDataChannelHandler* createDataChannel(
const blink::WebString& label,
const blink::WebRTCDataChannelInit& init) override;
- virtual blink::WebRTCDTMFSenderHandler* createDTMFSender(
+ blink::WebRTCDTMFSenderHandler* createDTMFSender(
const blink::WebMediaStreamTrack& track) override;
- virtual void stop() override;
+ void stop() override;
// WebTask related methods
WebTaskList* mutable_task_list() { return &task_list_; }
« no previous file with comments | « components/test_runner/mock_webrtc_dtmf_sender_handler.h ('k') | components/test_runner/spell_check_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698