Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: components/test_runner/mock_screen_orientation_client.h

Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/mock_screen_orientation_client.h
diff --git a/components/test_runner/mock_screen_orientation_client.h b/components/test_runner/mock_screen_orientation_client.h
index 2a2b442a5122a020776292beb84cb3cec8aca48e..ad868541ca17b2b4a1d6fd1f4c52beabf98d1cc2 100644
--- a/components/test_runner/mock_screen_orientation_client.h
+++ b/components/test_runner/mock_screen_orientation_client.h
@@ -23,7 +23,7 @@ class TEST_RUNNER_EXPORT MockScreenOrientationClient
: public NON_EXPORTED_BASE(blink::WebScreenOrientationClient) {
public:
explicit MockScreenOrientationClient();
- virtual ~MockScreenOrientationClient();
+ ~MockScreenOrientationClient() override;
void ResetData();
void UpdateDeviceOrientation(blink::WebLocalFrame* main_frame,
@@ -34,9 +34,9 @@ class TEST_RUNNER_EXPORT MockScreenOrientationClient
private:
// From blink::WebScreenOrientationClient.
- virtual void lockOrientation(blink::WebScreenOrientationLockType orientation,
- blink::WebLockOrientationCallback* callback);
- virtual void unlockOrientation();
+ void lockOrientation(blink::WebScreenOrientationLockType orientation,
+ blink::WebLockOrientationCallback* callback) override;
+ void unlockOrientation() override;
void UpdateLockSync(blink::WebScreenOrientationLockType,
blink::WebLockOrientationCallback*);
« no previous file with comments | « components/test_runner/mock_credential_manager_client.h ('k') | components/test_runner/mock_web_audio_device.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698