components/test_runner/mock_webrtc_dtmf_sender_handler.h - Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/mock_webrtc_dtmf_sender_handler.h

Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/mock_webrtc_data_channel_handler.h ('k') | components/test_runner/mock_webrtc_peer_connection_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/mock_webrtc_dtmf_sender_handler.h

diff --git a/components/test_runner/mock_webrtc_dtmf_sender_handler.h b/components/test_runner/mock_webrtc_dtmf_sender_handler.h

index a42c197e338bf5db9a0536ece3bb6cc859e3a414..955ef85fecf013e134a0bbb60bb6123c73d5072b 100644

--- a/components/test_runner/mock_webrtc_dtmf_sender_handler.h

+++ b/components/test_runner/mock_webrtc_dtmf_sender_handler.h

@@ -21,12 +21,12 @@ class MockWebRTCDTMFSenderHandler : public blink::WebRTCDTMFSenderHandler {

WebTestDelegate* delegate);

// WebRTCDTMFSenderHandler related methods

- virtual void setClient(blink::WebRTCDTMFSenderHandlerClient* client) override;

- virtual blink::WebString currentToneBuffer() override;

- virtual bool canInsertDTMF() override;

- virtual bool insertDTMF(const blink::WebString& tones,

- long duration,

- long inter_tone_gap) override;

+ void setClient(blink::WebRTCDTMFSenderHandlerClient* client) override;

+ blink::WebString currentToneBuffer() override;

+ bool canInsertDTMF() override;

+ bool insertDTMF(const blink::WebString& tones,

+ long duration,

+ long inter_tone_gap) override;

// WebTask related methods

WebTaskList* mutable_task_list() { return &task_list_; }