Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: components/test_runner/web_content_settings.h

Issue 1360123005: Enforce marking "override" for functions overriding Blink in components/test_runner/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/test_plugin.h ('k') | components/test_runner/web_test_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_content_settings.h
diff --git a/components/test_runner/web_content_settings.h b/components/test_runner/web_content_settings.h
index 89dd99df29b5e1332f71ad8bb022674c3b29ef23..dab51edc6c0552144720a069f8e8efd6faec088e 100644
--- a/components/test_runner/web_content_settings.h
+++ b/components/test_runner/web_content_settings.h
@@ -15,22 +15,22 @@ class WebTestDelegate;
class WebContentSettings : public blink::WebContentSettingsClient {
public:
WebContentSettings();
- virtual ~WebContentSettings();
+ ~WebContentSettings() override;
// blink::WebContentSettingsClient:
- virtual bool allowImage(bool enabledPerSettings,
- const blink::WebURL& imageURL);
- virtual bool allowMedia(const blink::WebURL& mediaURL);
- virtual bool allowScriptFromSource(bool enabledPerSettings,
- const blink::WebURL& scriptURL);
- virtual bool allowStorage(bool local);
- virtual bool allowPlugins(bool enabledPerSettings);
- virtual bool allowDisplayingInsecureContent(bool enabledPerSettings,
- const blink::WebSecurityOrigin&,
- const blink::WebURL&);
- virtual bool allowRunningInsecureContent(bool enabledPerSettings,
- const blink::WebSecurityOrigin&,
- const blink::WebURL&);
+ bool allowImage(bool enabledPerSettings,
+ const blink::WebURL& imageURL) override;
+ bool allowMedia(const blink::WebURL& mediaURL) override;
+ bool allowScriptFromSource(bool enabledPerSettings,
+ const blink::WebURL& scriptURL) override;
+ bool allowStorage(bool local) override;
+ bool allowPlugins(bool enabledPerSettings) override;
+ bool allowDisplayingInsecureContent(bool enabledPerSettings,
+ const blink::WebSecurityOrigin&,
+ const blink::WebURL&) override;
+ bool allowRunningInsecureContent(bool enabledPerSettings,
+ const blink::WebSecurityOrigin&,
+ const blink::WebURL&) override;
// Hooks to set the different policies.
void SetImagesAllowed(bool);
« no previous file with comments | « components/test_runner/test_plugin.h ('k') | components/test_runner/web_test_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698