Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 134593005: Update SVG classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, Steve Block, krit, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, shans, f(malita), darktears, pdr, Stephen Chennney, Eric Willigers, dino_apple.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update SVG classes to use OVERRIDE / FINAL when needed Update SVG classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, schenney, eseidel BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -633 lines) Patch
M Source/core/svg/SVGAElement.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGAltGlyphElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimateTransformElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedAngle.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedBoolean.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedColor.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedEnumeration.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedInteger.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedIntegerOptionalInteger.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedNewPropertyAnimator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedNumber.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumberList.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumberOptionalNumber.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedPath.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedPointList.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedPreserveAspectRatio.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedRect.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedString.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimatedTransformList.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGCircleElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGCursorElement.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGDefsElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDescElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGDocument.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.h View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGElementInstance.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEBlendElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFECompositeElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEDistantLightElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEFloodElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFELightElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEMergeElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMergeNodeElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEOffsetElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEPointLightElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFESpotLightElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFETileElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFilterElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGFontElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceFormatElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGGElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGGlyphElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGlyphRefElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGHKernElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGImageLoader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLength.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLengthList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLengthListTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLengthTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLineElement.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGMPathElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGMaskElement.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGMissingGlyphElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPathBuilder.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathByteStreamBuilder.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathByteStreamSource.h View 2 chunks +15 lines, -15 lines 0 comments Download
M Source/core/svg/SVGPathElement.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathSegArcAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegArcRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegClosePath.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegListBuilder.h View 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathSegListSource.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoAbs.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoRel.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathStringBuilder.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathStringSource.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPathTraversalStateBuilder.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGPolyElement.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGRadialGradientElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGRectElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGSVGElement.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGScriptElement.h View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/core/svg/SVGStopElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyleElement.h View 2 chunks +7 lines, -8 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGSymbolElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTSpanElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTextElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTextPositioningElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTitleElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUnknownElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/svg/SVGVKernElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGViewElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGZoomEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilter.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 11 months ago (2014-01-10 23:51:30 UTC) #1
pdr.
On 2014/01/10 23:51:30, Chris Dumez wrote: Wow! LGTM, rs=me. Are you using a script to ...
6 years, 11 months ago (2014-01-10 23:57:41 UTC) #2
Inactive
On 2014/01/10 23:57:41, pdr wrote: > On 2014/01/10 23:51:30, Chris Dumez wrote: > > Wow! ...
6 years, 11 months ago (2014-01-10 23:59:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/134593005/1
6 years, 11 months ago (2014-01-11 00:06:24 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 00:27:21 UTC) #5
Message was sent while issue was closed.
Change committed as 164912

Powered by Google App Engine
This is Rietveld 408576698