Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Side by Side Diff: Source/core/svg/SVGFilterPrimitiveStandardAttributes.h

Issue 134593005: Update SVG classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGFilterElement.h ('k') | Source/core/svg/SVGFontElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 SVGAnimatedLength* x() const { return m_x.get(); } 46 SVGAnimatedLength* x() const { return m_x.get(); }
47 SVGAnimatedLength* y() const { return m_y.get(); } 47 SVGAnimatedLength* y() const { return m_y.get(); }
48 SVGAnimatedLength* width() const { return m_width.get(); } 48 SVGAnimatedLength* width() const { return m_width.get(); }
49 SVGAnimatedLength* height() const { return m_height.get(); } 49 SVGAnimatedLength* height() const { return m_height.get(); }
50 50
51 protected: 51 protected:
52 SVGFilterPrimitiveStandardAttributes(const QualifiedName&, Document&); 52 SVGFilterPrimitiveStandardAttributes(const QualifiedName&, Document&);
53 53
54 bool isSupportedAttribute(const QualifiedName&); 54 bool isSupportedAttribute(const QualifiedName&);
55 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 55 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
56 virtual void svgAttributeChanged(const QualifiedName&); 56 virtual void svgAttributeChanged(const QualifiedName&) OVERRIDE;
57 virtual void childrenChanged(bool changedByParser = false, Node* beforeChang e = 0, Node* afterChange = 0, int childCountDelta = 0); 57 virtual void childrenChanged(bool changedByParser = false, Node* beforeChang e = 0, Node* afterChange = 0, int childCountDelta = 0) OVERRIDE;
58 58
59 inline void invalidate() 59 inline void invalidate()
60 { 60 {
61 if (RenderObject* primitiveRenderer = renderer()) 61 if (RenderObject* primitiveRenderer = renderer())
62 RenderSVGResource::markForLayoutAndParentResourceInvalidation(primit iveRenderer); 62 RenderSVGResource::markForLayoutAndParentResourceInvalidation(primit iveRenderer);
63 } 63 }
64 64
65 void primitiveAttributeChanged(const QualifiedName&); 65 void primitiveAttributeChanged(const QualifiedName&);
66 66
67 private: 67 private:
68 virtual bool isFilterEffect() const { return true; } 68 virtual bool isFilterEffect() const OVERRIDE FINAL { return true; }
69 69
70 virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE; 70 virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE FINAL;
71 virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE; 71 virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE FINAL;
72 virtual bool childShouldCreateRenderer(const Node& child) const OVERRIDE { r eturn false; } 72 virtual bool childShouldCreateRenderer(const Node& child) const OVERRIDE FIN AL { return false; }
73 73
74 RefPtr<SVGAnimatedLength> m_x; 74 RefPtr<SVGAnimatedLength> m_x;
75 RefPtr<SVGAnimatedLength> m_y; 75 RefPtr<SVGAnimatedLength> m_y;
76 RefPtr<SVGAnimatedLength> m_width; 76 RefPtr<SVGAnimatedLength> m_width;
77 RefPtr<SVGAnimatedLength> m_height; 77 RefPtr<SVGAnimatedLength> m_height;
78 BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGFilterPrimitiveStandardAttributes) 78 BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGFilterPrimitiveStandardAttributes)
79 DECLARE_ANIMATED_STRING(Result, result) 79 DECLARE_ANIMATED_STRING(Result, result)
80 END_DECLARE_ANIMATED_PROPERTIES 80 END_DECLARE_ANIMATED_PROPERTIES
81 }; 81 };
82 82
83 void invalidateFilterPrimitiveParent(SVGElement*); 83 void invalidateFilterPrimitiveParent(SVGElement*);
84 84
85 } // namespace WebCore 85 } // namespace WebCore
86 86
87 #endif 87 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGFilterElement.h ('k') | Source/core/svg/SVGFontElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698