Source/core/svg/SVGTextPathElement.h - Issue 134593005: Update SVG classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGTextPathElement.h

Issue 134593005: Update SVG classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGTextPathElement.h

diff --git a/Source/core/svg/SVGTextPathElement.h b/Source/core/svg/SVGTextPathElement.h

index adb4369df74109d1398524698720381be8a90b7b..c45bbcf8b1a2106be3d5f60c245a2f30fdfff640 100644

--- a/Source/core/svg/SVGTextPathElement.h

+++ b/Source/core/svg/SVGTextPathElement.h

@@ -120,19 +120,19 @@ private:

void clearResourceReferences();

- virtual void buildPendingResource();

+ virtual void buildPendingResource() OVERRIDE;

virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;

virtual void removedFrom(ContainerNode*) OVERRIDE;

bool isSupportedAttribute(const QualifiedName&);

virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;

- virtual void svgAttributeChanged(const QualifiedName&);

+ virtual void svgAttributeChanged(const QualifiedName&) OVERRIDE;

- virtual RenderObject* createRenderer(RenderStyle*);

- virtual bool childShouldCreateRenderer(const Node& child) const;

- virtual bool rendererIsNeeded(const RenderStyle&);

+ virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE;

+ virtual bool childShouldCreateRenderer(const Node& child) const OVERRIDE;

+ virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE;

- virtual bool selfHasRelativeLengths() const;

+ virtual bool selfHasRelativeLengths() const OVERRIDE;

RefPtr<SVGAnimatedLength> m_startOffset;

BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGTextPathElement)

« no previous file with comments | « Source/core/svg/SVGTextElement.h ('k') | Source/core/svg/SVGTextPositioningElement.h » ('j') | no next file with comments »