Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1344943002: fix up GrGLProgrambuilder precision on varyings (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix up GrGLProgrambuilder precision on varyings TBR= BUG=skia:4347 Committed: https://skia.googlesource.com/skia/+/eb00eaba0cb0be4ba39a7c00b6be8347136ce4ae

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
joshualitt
ptal
5 years, 3 months ago (2015-09-15 21:02:29 UTC) #3
ethannicholas
lgtm
5 years, 3 months ago (2015-09-15 21:06:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344943002/20001
5 years, 3 months ago (2015-09-15 21:06:41 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-15 21:06:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344943002/20001
5 years, 3 months ago (2015-09-15 21:09:11 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 21:12:26 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/eb00eaba0cb0be4ba39a7c00b6be8347136ce4ae

Powered by Google App Engine
This is Rietveld 408576698