Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 134473008: Remove CSS regions support, keeping a bare minimum to support "region-based" multicol. (Closed)

Created:
6 years, 10 months ago by mstensho (USE GERRIT)
Modified:
6 years, 10 months ago
Reviewers:
ojan, lushnikov, eseidel
CC:
blink-reviews, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, Nils Barth (inactive), blink-layers+watch_chromium.org, caseq+blink_chromium.org, Nate Chapin, arv+blink, chromiumbugtracker_adobe.com, bemjb+rendering_chromium.org, dsinclair, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., rwlbuis, mstensho+blink_opera.com, jfernandez, philipj_slow, loislo+blink_chromium.org, zoltan1, Manuel Rego, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, haraken, krit, kojih, jsbell+bindings_chromium.org, feature-media-reviews_chromium.org, svillar, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove CSS regions support, keeping a bare minimum to support "region-based" multicol. Remove everything strictly specific to CSS regions, but keep the parts that "region-based" multicol needs. So the render flow thread framework is still around, albeit heavily trimmed down. RenderRegion has also been kept, but is now obviously a misnomer (to be fixed later). It serves as a base class for what css3-break refers to as a "fragmentainer" (e.g. column, page or region). Not sure if it should really be a renderer type, seeing that these need to be created during layout (which should be avoided for renderers). A fragmentainer is more akin to what a line box represents than to what a renderer does. Additional removal and cleanup is possible, but let's start with this. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167275

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase master #

Patch Set 3 : Code review: Revert changes in Source/devtools/Inspector-1.1.json #

Total comments: 4

Patch Set 4 : Code review #

Patch Set 5 : Rebase master #

Patch Set 6 : Rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -5437 lines) Patch
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CSSRuleCustom.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 chunks +0 lines, -15 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 4 4 chunks +0 lines, -24 lines 0 comments Download
M Source/core/css/CSSGrammar.y View 8 chunks +0 lines, -62 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 3 4 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSPropertySourceData.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/css/CSSRegionRule.h View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/core/css/CSSRegionRule.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M Source/core/css/CSSRule.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSRule.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSRule.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSTokenizer-in.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/ElementRuleCollector.h View 4 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 3 chunks +0 lines, -18 lines 0 comments Download
M Source/core/css/RuleSet.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 1 2 3 4 5 3 chunks +0 lines, -29 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/css/StyleInvalidationAnalysis.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/StyleRule.h View 4 chunks +0 lines, -21 lines 0 comments Download
M Source/core/css/StyleRule.cpp View 5 chunks +0 lines, -24 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 2 3 4 5 2 chunks +1 line, -5 lines 0 comments Download
D Source/core/css/WebKitCSSRegionRule.idl View 1 chunk +0 lines, -36 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 4 chunks +0 lines, -8 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 3 4 6 chunks +0 lines, -127 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 4 5 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 4 chunks +1 line, -19 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 8 chunks +2 lines, -33 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 3 chunks +1 line, -9 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.cpp View 1 chunk +1 line, -2 lines 0 comments Download
D Source/core/dom/DOMNamedFlowCollection.h View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/dom/DOMNamedFlowCollection.cpp View 1 chunk +0 lines, -90 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 4 5 4 chunks +0 lines, -8 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 3 chunks +0 lines, -20 lines 0 comments Download
M Source/core/dom/Document.idl View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 1 2 3 4 5 5 chunks +0 lines, -14 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 5 5 chunks +0 lines, -94 lines 0 comments Download
M Source/core/dom/Element.idl View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 3 chunks +0 lines, -11 lines 0 comments Download
M Source/core/dom/ElementRareData.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
D Source/core/dom/NamedFlow.h View 1 chunk +0 lines, -93 lines 0 comments Download
D Source/core/dom/NamedFlow.cpp View 1 chunk +0 lines, -249 lines 0 comments Download
D Source/core/dom/NamedFlowCollection.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/dom/NamedFlowCollection.cpp View 1 2 3 4 1 chunk +0 lines, -129 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 3 4 5 4 chunks +3 lines, -8 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/NodeRenderingTraversal.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/PseudoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/PseudoElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.h View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 5 chunks +1 line, -81 lines 0 comments Download
D Source/core/dom/WebKitNamedFlow.idl View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/dom/WebKitNamedFlowCollection.idl View 1 chunk +0 lines, -39 lines 0 comments Download
M Source/core/events/EventTarget.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventTargetFactory.in View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventTypeNames.in View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 4 5 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/FixedTableLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/FlowThreadController.h View 1 chunk +4 lines, -47 lines 0 comments Download
M Source/core/rendering/FlowThreadController.cpp View 1 chunk +4 lines, -206 lines 0 comments Download
M Source/core/rendering/HitTestLocation.h View 4 chunks +1 line, -7 lines 0 comments Download
M Source/core/rendering/HitTestLocation.cpp View 7 chunks +2 lines, -10 lines 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/LayerPaintingInfo.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/rendering/PaintInfo.h View 3 chunks +1 line, -4 lines 0 comments Download
D Source/core/rendering/RegionOversetState.h View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 2 3 4 5 5 chunks +2 lines, -44 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 3 4 12 chunks +10 lines, -140 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 2 3 4 8 chunks +4 lines, -45 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 2 3 4 18 chunks +34 lines, -120 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 2 3 4 5 6 chunks +1 line, -16 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 9 chunks +9 lines, -17 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 3 4 5 40 chunks +42 lines, -282 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 6 chunks +6 lines, -13 lines 0 comments Download
D Source/core/rendering/RenderBoxRegionInfo.h View 1 chunk +0 lines, -59 lines 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 4 chunks +3 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.h View 8 chunks +2 lines, -71 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 1 2 3 4 24 chunks +7 lines, -512 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 3 4 5 21 chunks +24 lines, -25 lines 0 comments Download
M Source/core/rendering/RenderLayerClipper.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/rendering/RenderLayerClipper.cpp View 8 chunks +8 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerStackingNode.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderMedia.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.h View 1 chunk +0 lines, -4 lines 0 comments Download
D Source/core/rendering/RenderNamedFlowFragment.h View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/core/rendering/RenderNamedFlowFragment.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
D Source/core/rendering/RenderNamedFlowThread.h View 1 chunk +0 lines, -144 lines 0 comments Download
D Source/core/rendering/RenderNamedFlowThread.cpp View 1 2 3 4 1 chunk +0 lines, -727 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 5 chunks +1 line, -7 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 3 4 5 10 chunks +1 line, -70 lines 0 comments Download
M Source/core/rendering/RenderRegion.h View 5 chunks +0 lines, -106 lines 0 comments Download
M Source/core/rendering/RenderRegion.cpp View 1 2 3 4 5 12 chunks +3 lines, -463 lines 0 comments Download
M Source/core/rendering/RenderRegionSet.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderRegionSet.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderReplica.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 2 3 4 4 chunks +6 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 4 chunks +2 lines, -95 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 2 3 4 5 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 2 3 4 5 4 chunks +2 lines, -69 lines 0 comments Download
M Source/core/rendering/RootInlineBox.h View 1 2 3 4 3 chunks +1 line, -9 lines 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 1 2 3 4 2 chunks +1 line, -24 lines 0 comments Download
M Source/core/rendering/line/BreakingContextInlineHeaders.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 2 3 4 6 chunks +0 lines, -25 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 3 4 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -18 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
mstensho (USE GERRIT)
Depends on https://codereview.chromium.org/159933010/ (removal of CSS regions tests)
6 years, 10 months ago (2014-02-12 10:15:58 UTC) #1
lushnikov
On 2014/02/12 10:15:58, Morten Stenshorne wrote: > Depends on https://codereview.chromium.org/159933010/ (removal of CSS regions > ...
6 years, 10 months ago (2014-02-13 17:14:35 UTC) #2
mstensho (USE GERRIT)
Sure, go ahead and land https://codereview.chromium.org/163413005/ first. https://codereview.chromium.org/134473008/diff/1/Source/devtools/Inspector-1.1.json File Source/devtools/Inspector-1.1.json (left): https://codereview.chromium.org/134473008/diff/1/Source/devtools/Inspector-1.1.json#oldcode2520 Source/devtools/Inspector-1.1.json:2520: "id": "Region", ...
6 years, 10 months ago (2014-02-13 20:23:27 UTC) #3
eseidel
lgtm Wow. Such a huge feature. Thank you for working on this. I would have ...
6 years, 10 months ago (2014-02-14 11:44:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/134473008/80001
6 years, 10 months ago (2014-02-14 11:44:42 UTC) #5
eseidel
The CQ bit was unchecked by eseidel@chromium.org
6 years, 10 months ago (2014-02-14 11:44:49 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 11:45:24 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Document.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-14 11:45:25 UTC) #8
mstensho (USE GERRIT)
Waiting for https://codereview.chromium.org/163413005/ to land. https://codereview.chromium.org/134473008/diff/80001/Source/core/dom/Node.h File Source/core/dom/Node.h (right): https://codereview.chromium.org/134473008/diff/80001/Source/core/dom/Node.h#newcode719 Source/core/dom/Node.h:719: NeedsStyleInvalidation = 1 << ...
6 years, 10 months ago (2014-02-14 12:06:11 UTC) #9
lushnikov
On 2014/02/14 12:06:11, Morten Stenshorne wrote: > Waiting for https://codereview.chromium.org/163413005/ to land. > > https://codereview.chromium.org/134473008/diff/80001/Source/core/dom/Node.h ...
6 years, 10 months ago (2014-02-14 14:50:55 UTC) #10
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 10 months ago (2014-02-14 15:12:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/134473008/220001
6 years, 10 months ago (2014-02-14 15:12:43 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 19:02:56 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=27331
6 years, 10 months ago (2014-02-14 19:02:57 UTC) #14
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 10 months ago (2014-02-14 20:08:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/134473008/220001
6 years, 10 months ago (2014-02-14 20:08:56 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 20:09:39 UTC) #17
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/RenderRegion.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-14 20:09:40 UTC) #18
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 10 months ago (2014-02-17 09:12:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/134473008/540001
6 years, 10 months ago (2014-02-17 09:12:59 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 11:29:03 UTC) #21
Message was sent while issue was closed.
Change committed as 167275

Powered by Google App Engine
This is Rietveld 408576698