Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: Source/core/rendering/RenderMultiColumnSet.h

Issue 134473008: Remove CSS regions support, keeping a bare minimum to support "region-based" multicol. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase master Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderMedia.cpp ('k') | Source/core/rendering/RenderNamedFlowFragment.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 virtual void paintObject(PaintInfo&, const LayoutPoint& paintOffset) OVERRID E; 90 virtual void paintObject(PaintInfo&, const LayoutPoint& paintOffset) OVERRID E;
91 91
92 virtual LayoutUnit pageLogicalWidth() const OVERRIDE { return m_computedColu mnWidth; } 92 virtual LayoutUnit pageLogicalWidth() const OVERRIDE { return m_computedColu mnWidth; }
93 virtual LayoutUnit pageLogicalHeight() const OVERRIDE { return m_computedCol umnHeight; } 93 virtual LayoutUnit pageLogicalHeight() const OVERRIDE { return m_computedCol umnHeight; }
94 94
95 virtual LayoutUnit pageLogicalTopForOffset(LayoutUnit offset) const OVERRIDE ; 95 virtual LayoutUnit pageLogicalTopForOffset(LayoutUnit offset) const OVERRIDE ;
96 96
97 // FIXME: This will change once we have column sets constrained by enclosing pages, etc. 97 // FIXME: This will change once we have column sets constrained by enclosing pages, etc.
98 virtual LayoutUnit logicalHeightOfAllFlowThreadContent() const OVERRIDE { re turn m_computedColumnHeight; } 98 virtual LayoutUnit logicalHeightOfAllFlowThreadContent() const OVERRIDE { re turn m_computedColumnHeight; }
99 99
100 // FIXME: For now we return false, but it's likely we will leverage the auto height region code to do column
101 // balancing. That's why we have an override of this function that is distin ct from RenderRegionSet's override.
102 virtual bool shouldHaveAutoLogicalHeight() const OVERRIDE { return false; }
103
104 virtual void repaintFlowThreadContent(const LayoutRect& repaintRect) const O VERRIDE; 100 virtual void repaintFlowThreadContent(const LayoutRect& repaintRect) const O VERRIDE;
105 101
106 virtual void collectLayerFragments(LayerFragments&, const LayoutRect& layerB oundingBox, const LayoutRect& dirtyRect) OVERRIDE; 102 virtual void collectLayerFragments(LayerFragments&, const LayoutRect& layerB oundingBox, const LayoutRect& dirtyRect) OVERRIDE;
107 103
108 virtual const char* renderName() const OVERRIDE; 104 virtual const char* renderName() const OVERRIDE;
109 105
110 void paintColumnRules(PaintInfo&, const LayoutPoint& paintOffset); 106 void paintColumnRules(PaintInfo&, const LayoutPoint& paintOffset);
111 107
112 LayoutUnit columnGap() const; 108 LayoutUnit columnGap() const;
113 LayoutRect columnRectAt(unsigned index) const; 109 LayoutRect columnRectAt(unsigned index) const;
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 }; 167 };
172 Vector<ContentRun, 1> m_contentRuns; 168 Vector<ContentRun, 1> m_contentRuns;
173 }; 169 };
174 170
175 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMultiColumnSet, isRenderMultiColumnSet()); 171 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMultiColumnSet, isRenderMultiColumnSet());
176 172
177 } // namespace WebCore 173 } // namespace WebCore
178 174
179 #endif // RenderMultiColumnSet_h 175 #endif // RenderMultiColumnSet_h
180 176
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderMedia.cpp ('k') | Source/core/rendering/RenderNamedFlowFragment.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698