Create fragment processor for performing input color blend with child processor

Create fragment processor for performing input color blend with child processor

The new FP is used to implement SkXM::Mode color filters and SkXM::Mode image filters. Also, these now support all advanced SkXM::Mode xfermodes.

Committed: https://skia.googlesource.com/skia/+/ae4738f677c70f4ec7687422e1510ee3d80d810e

[bsalomon, 2015-09-15 19:13:31]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2015-09-15 20:59:28]

https://codereview.chromium.org/1334293003/diff/80001/include/gpu/GrColor.h
File include/gpu/GrColor.h (right):

https://codereview.chromium.org/1334293003/diff/80001/include/gpu/GrColor.h#n...
include/gpu/GrColor.h:160: SkPMColor colorPM = SkPackARGB32(a, r, g, b);
maybe use your new helper GrColorToSkPMColor here?

https://codereview.chromium.org/1334293003/diff/80001/src/gpu/effects/GrXferm...
File src/gpu/effects/GrXfermodeFragmentProcessor.cpp (right):

https://codereview.chromium.org/1334293003/diff/80001/src/gpu/effects/GrXferm...
src/gpu/effects/GrXfermodeFragmentProcessor.cpp:160:
this->initClassID<ComposeTwoFragmentProcessor>();
ComposeOneFrag

https://codereview.chromium.org/1334293003/diff/80001/src/gpu/effects/GrXferm...
src/gpu/effects/GrXfermodeFragmentProcessor.cpp:168: b->add32(fMode | (fChild <<
16));
worth asserting that kLastMode (or whatever it is called) is less then 16 bits?

[bsalomon, 2015-09-15 21:12:07]

https://codereview.chromium.org/1334293003/diff/80001/include/gpu/GrColor.h
File include/gpu/GrColor.h (right):

https://codereview.chromium.org/1334293003/diff/80001/include/gpu/GrColor.h#n...
include/gpu/GrColor.h:160: SkPMColor colorPM = SkPackARGB32(a, r, g, b);
On 2015/09/15 20:59:28, egdaniel wrote:
> maybe use your new helper GrColorToSkPMColor here?

now that is moved out I think the minor code duplication is better than
including all of SkGr.h in here.

https://codereview.chromium.org/1334293003/diff/80001/src/gpu/effects/GrXferm...
File src/gpu/effects/GrXfermodeFragmentProcessor.cpp (right):

https://codereview.chromium.org/1334293003/diff/80001/src/gpu/effects/GrXferm...
src/gpu/effects/GrXfermodeFragmentProcessor.cpp:160:
this->initClassID<ComposeTwoFragmentProcessor>();
On 2015/09/15 20:59:28, egdaniel wrote:
> ComposeOneFrag

eek... nice catch.

https://codereview.chromium.org/1334293003/diff/80001/src/gpu/effects/GrXferm...
src/gpu/effects/GrXfermodeFragmentProcessor.cpp:168: b->add32(fMode | (fChild <<
16));
On 2015/09/15 20:59:28, egdaniel wrote:
> worth asserting that kLastMode (or whatever it is called) is less then 16
bits?

Done.

[bsalomon, 2015-09-15 21:12:16]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-15 21:12:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1334293003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1334293003/120001

[commit-bot: I haz the power, 2015-09-15 21:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 21:13:17]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[egdaniel, 2015-09-15 21:24:17]

lgtm

[bsalomon, 2015-09-15 21:24:22]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-15 21:24:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1334293003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1334293003/140001

[commit-bot: I haz the power, 2015-09-15 21:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 21:26:04]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2015-09-15 21:34:07]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-09-15 21:34:07]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1334293003/#ps180001
(title: "rm unused functions and revert circle blur change")

[commit-bot: I haz the power, 2015-09-15 21:34:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1334293003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1334293003/180001

[commit-bot: I haz the power, 2015-09-15 21:35:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 21:35:24]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2015-09-15 22:23:13]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-09-15 22:23:13]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1334293003/#ps220001
(title: "rebase")

[commit-bot: I haz the power, 2015-09-15 22:23:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1334293003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1334293003/220001

[commit-bot: I haz the power, 2015-09-15 22:24:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 22:24:29]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[bsalomon, 2015-09-15 22:26:47]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-09-15 22:26:48]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1334293003/#ps240001
(title: "fix")

[commit-bot: I haz the power, 2015-09-15 22:26:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1334293003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1334293003/240001

[commit-bot: I haz the power, 2015-09-15 22:33:32]

Committed patchset #13 (id:240001) as
https://skia.googlesource.com/skia/+/ae4738f677c70f4ec7687422e1510ee3d80d810e