Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313573005: Revert of Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* (Closed)

Created:
5 years, 3 months ago by rmistry
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@things
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* (patchset #8 id:140001 of https://codereview.chromium.org/1316513002/ ) Reason for revert: Primary suspect in failing DEPS rolls: * https://codereview.chromium.org/1315753006 * https://codereview.chromium.org/1308323006 * https://codereview.chromium.org/1320903004 Primary suspect because the failing win bots did not fail in https://codereview.chromium.org/1315753005 Original issue's description: > Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor* > > Committed: https://skia.googlesource.com/skia/+/ecfdc251be71f3d634e76afdd6375bf55fc061aa TBR=joshualitt@google.com,wangyix@google.com,robertphillips@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/a511e6ad1042093bea5b015c22a920313fc57c0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -388 lines) Patch
M gm/dcshader.cpp View 3 chunks +10 lines, -7 lines 0 comments Download
M gyp/gpu.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +21 lines, -14 lines 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 1 chunk +3 lines, -5 lines 0 comments Download
M include/gpu/GrFragmentProcessor.h View 2 chunks +1 line, -4 lines 0 comments Download
M include/gpu/GrProcessorUnitTest.h View 3 chunks +8 lines, -8 lines 0 comments Download
M include/gpu/effects/GrConstColorProcessor.h View 2 chunks +4 lines, -0 lines 0 comments Download
D include/gpu/effects/GrExtractAlphaFragmentProcessor.h View 1 chunk +0 lines, -45 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 4 chunks +32 lines, -23 lines 0 comments Download
M src/core/SkColorShader.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/core/SkLightingShader.cpp View 5 chunks +33 lines, -22 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 1 chunk +17 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +16 lines, -6 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +22 lines, -10 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 15 chunks +59 lines, -33 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 4 chunks +28 lines, -15 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 4 chunks +28 lines, -13 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 4 chunks +27 lines, -15 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +23 lines, -9 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 10 chunks +39 lines, -22 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +16 lines, -7 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
Created Revert of Change SkShader;asFragmentProcessor signature to no longer take skpaint\grcolor*
5 years, 3 months ago (2015-08-29 00:16:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313573005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313573005/1
5 years, 3 months ago (2015-08-29 00:16:33 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 00:16:55 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a511e6ad1042093bea5b015c22a920313fc57c0b

Powered by Google App Engine
This is Rietveld 408576698