Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310883002: DevTools: represent ComputedStyle with simple Map (Closed)

Created:
5 years, 4 months ago by lushnikov
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: represent ComputedStyle with simple Map Use simple Map<string, string> object Instead of utilizing CSSStyleDeclaration for representation of computed style. NOTRY=true BUG=496263 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201077

Patch Set 1 #

Patch Set 2 : fix test #

Total comments: 2

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310883002/1
5 years, 4 months ago (2015-08-22 00:18:47 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102741)
5 years, 4 months ago (2015-08-22 01:18:56 UTC) #4
lushnikov
ptal
5 years, 4 months ago (2015-08-24 04:00:52 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310883002/20001
5 years, 4 months ago (2015-08-24 04:00:57 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102913)
5 years, 4 months ago (2015-08-24 05:25:21 UTC) #10
pfeldman
https://codereview.chromium.org/1310883002/diff/20001/LayoutTests/inspector/elements/hide-shortcut.html File LayoutTests/inspector/elements/hide-shortcut.html (right): https://codereview.chromium.org/1310883002/diff/20001/LayoutTests/inspector/elements/hide-shortcut.html#newcode65 LayoutTests/inspector/elements/hide-shortcut.html:65: InspectorTest.addResult(getPropertyText(style, "visibility")); This patch does not apply.
5 years, 4 months ago (2015-08-24 17:48:01 UTC) #11
pfeldman
lgtm https://codereview.chromium.org/1310883002/diff/20001/LayoutTests/inspector/elements/hide-shortcut.html File LayoutTests/inspector/elements/hide-shortcut.html (right): https://codereview.chromium.org/1310883002/diff/20001/LayoutTests/inspector/elements/hide-shortcut.html#newcode65 LayoutTests/inspector/elements/hide-shortcut.html:65: InspectorTest.addResult(getPropertyText(style, "visibility")); On 2015/08/24 17:48:01, pfeldman wrote: > ...
5 years, 4 months ago (2015-08-24 20:55:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310883002/20001
5 years, 4 months ago (2015-08-24 22:00:40 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103376)
5 years, 4 months ago (2015-08-24 23:00:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310883002/20001
5 years, 4 months ago (2015-08-24 23:16:07 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 23:21:36 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201077

Powered by Google App Engine
This is Rietveld 408576698