Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1336803005: DevTools: use diff_match_patch instead of jsdifflib for text diffing. (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: use diff_match_patch instead of jsdifflib for text diffing. The diff_match_patch is a highly optimized google-owned library for text diffing. The patch creates a new module "diff" which other modules can depend on to perform BUG=527993 R=pfeldman Committed: https://crrev.com/ca1a0cd45313d38f188c8c2ba278a705216cbc1a git-svn-id: svn://svn.chromium.org/blink/trunk@202290 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : stray line #

Patch Set 3 : rebaseline #

Patch Set 4 : fix file permissions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -457 lines) Patch
M LayoutTests/inspector/initial-modules-load-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/BUILD.gn View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 2 3 chunks +5 lines, -1 line 0 comments Download
A Source/devtools/front_end/diff/Diff.js View 1 chunk +56 lines, -0 lines 0 comments Download
A Source/devtools/front_end/diff/diff_match_patch.js View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
A Source/devtools/front_end/diff/module.json View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/externs.js View 1 2 1 chunk +15 lines, -6 lines 0 comments Download
M Source/devtools/front_end/inspector.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/FilteredItemSelectionDialog.js View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sources/RevisionHistoryView.js View 1 chunk +23 lines, -31 lines 0 comments Download
D Source/devtools/front_end/sources/jsdifflib.js View 1 chunk +0 lines, -409 lines 0 comments Download
M Source/devtools/front_end/sources/module.json View 2 chunks +1 line, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (9 generated)
lushnikov
ptal
5 years, 3 months ago (2015-09-14 22:31:44 UTC) #1
lushnikov
Note: the diff_match_patch is distributed under Apache License 2.0. Should I add the license text ...
5 years, 3 months ago (2015-09-14 22:32:44 UTC) #2
pfeldman
lgtm On 2015/09/14 22:32:44, lushnikov wrote: > Note: the diff_match_patch is distributed under Apache License ...
5 years, 3 months ago (2015-09-14 22:37:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336803005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336803005/20001
5 years, 3 months ago (2015-09-14 22:43:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99608)
5 years, 3 months ago (2015-09-14 22:54:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336803005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336803005/20001
5 years, 3 months ago (2015-09-15 06:19:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99755)
5 years, 3 months ago (2015-09-15 06:26:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336803005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336803005/40001
5 years, 3 months ago (2015-09-15 16:48:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99905)
5 years, 3 months ago (2015-09-15 17:00:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336803005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336803005/60001
5 years, 3 months ago (2015-09-15 18:35:53 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202290
5 years, 3 months ago (2015-09-15 20:06:36 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:48:34 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ca1a0cd45313d38f188c8c2ba278a705216cbc1a

Powered by Google App Engine
This is Rietveld 408576698