Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1344833004: DevTools: extract PollManager from SASSSourceMapping (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: extract PollManager from SASSSourceMapping Extract all logic responsible for polling of a newly generated CSS file into a separate PollManager file. BUG=527993 R=pfeldman NOTRY=true Committed: https://crrev.com/3fd3203298731b47238c1e2832b6c4198d37d570 git-svn-id: svn://svn.chromium.org/blink/trunk@202312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -392 lines) Patch
M Source/devtools/front_end/bindings/SASSSourceMapping.js View 2 chunks +413 lines, -392 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
lushnikov
ptal
5 years, 3 months ago (2015-09-15 20:48:31 UTC) #1
pfeldman
lgtm
5 years, 3 months ago (2015-09-15 21:45:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344833004/1
5 years, 3 months ago (2015-09-15 21:48:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/107570)
5 years, 3 months ago (2015-09-15 23:51:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344833004/1
5 years, 3 months ago (2015-09-15 23:54:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202312
5 years, 3 months ago (2015-09-16 01:41:31 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:52:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3fd3203298731b47238c1e2832b6c4198d37d570

Powered by Google App Engine
This is Rietveld 408576698