Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313443005: DevTools: forward Up/Down keys to profiles sidebar from FlameChart (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: forward Up/Down keys to profiles sidebar from FlameChart The patch: - Adds forwarding of Up/Down events to Profile panel's sidebar pane. This happens if up/down is pressed while FlameChart is focused. - Fixes occasional bug which makes FlameChart frozen/dead. BUG=511072 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201445

Patch Set 1 #

Patch Set 2 : new approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ui/treeoutline.js View 1 2 chunks +34 lines, -8 lines 0 comments Download
M Source/devtools/front_end/ui_lazy/FlameChart.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1310883002 Patch 20001

Messages

Total messages: 6 (1 generated)
lushnikov
ptal. The r184172 could be viewed here: https://codereview.chromium.org/672553002
5 years, 3 months ago (2015-08-28 22:07:00 UTC) #1
pfeldman
On 2015/08/28 22:07:00, lushnikov wrote: > ptal. > > The r184172 could be viewed here: ...
5 years, 3 months ago (2015-08-28 22:47:08 UTC) #2
pfeldman
lgtm
5 years, 3 months ago (2015-08-29 00:32:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313443005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313443005/20001
5 years, 3 months ago (2015-08-29 00:42:47 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 02:06:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201445

Powered by Google App Engine
This is Rietveld 408576698