Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/devtools/front_end/audits/AuditRules.js

Issue 1310883002: DevTools: represent ComputedStyle with simple Map (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix test Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/inspector/elements/hide-shortcut.html ('K') | « LayoutTests/inspector/elements/hide-shortcut.html ('k') | Source/devtools/front_end/elements/ComputedStyleWidget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/audits/AuditRules.js
diff --git a/Source/devtools/front_end/audits/AuditRules.js b/Source/devtools/front_end/audits/AuditRules.js
index 53122eecf8cf6652de95bba0158ebf7cabd402ee..d14dcc89d5154fa6becbb892410113aec7286ca4 100644
--- a/Source/devtools/front_end/audits/AuditRules.js
+++ b/Source/devtools/front_end/audits/AuditRules.js
@@ -897,7 +897,7 @@ WebInspector.AuditRules.ImageDimensionsRule.prototype = {
if (completeSrc)
src = completeSrc;
- if (styles.computedStyle.getPropertyValue("position") === "absolute")
+ if (styles.computedStyle.get("position") === "absolute")
return;
if (styles.attributesStyle) {
@@ -961,7 +961,7 @@ WebInspector.AuditRules.ImageDimensionsRule.prototype = {
}
/**
- * @param {?WebInspector.CSSStyleDeclaration} computedStyle
+ * @param {?Map.<string, string>} computedStyle
*/
function computedCallback(computedStyle)
{
« LayoutTests/inspector/elements/hide-shortcut.html ('K') | « LayoutTests/inspector/elements/hide-shortcut.html ('k') | Source/devtools/front_end/elements/ComputedStyleWidget.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698