Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312893006: DevTools: revert back ComputedStylesSidebar (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: revert back ComputedStylesSidebar BUG=496263 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201395

Patch Set 1 #

Patch Set 2 : final strokes #

Patch Set 3 : nit #

Total comments: 2

Patch Set 4 : brand new design #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -172 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 2 3 1 chunk +27 lines, -10 lines 0 comments Download
M LayoutTests/inspector/elements/elements-panel-styles-expected.txt View 1 2 3 1 chunk +51 lines, -21 lines 0 comments Download
M LayoutTests/inspector/elements/styles-1/css-live-edit-expected.txt View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles-2/inactive-properties-expected.txt View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles-2/inherited-mixed-case-properties-expected.txt View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt View 1 2 3 2 chunks +46 lines, -20 lines 0 comments Download
M LayoutTests/inspector/elements/styles-2/lazy-computed-style-expected.txt View 1 2 3 1 chunk +19 lines, -8 lines 0 comments Download
M LayoutTests/inspector/elements/styles-2/region-style-crash-expected.txt View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles-3/styles-computed-trace-expected.txt View 1 2 3 1 chunk +45 lines, -19 lines 0 comments Download
M Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 2 3 6 chunks +114 lines, -35 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 2 chunks +1 line, -6 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSectionModel.js View 1 chunk +11 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 3 chunks +1 line, -12 lines 0 comments Download
M Source/devtools/front_end/elements/computedStyleSidebarPane.css View 1 2 3 1 chunk +71 lines, -31 lines 0 comments Download

Depends on Patchset:

Issue 1310883002 Patch 20001

Dependent Patchsets:

Issue 1315723004 Patch 1

Messages

Total messages: 18 (8 generated)
lushnikov
ptal. screenshot: http://i.imgur.com/0D0b1qN.png
5 years, 3 months ago (2015-08-27 18:50:08 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/1312893006/diff/40001/Source/devtools/front_end/elements/ComputedStyleWidget.js File Source/devtools/front_end/elements/ComputedStyleWidget.js (right): https://codereview.chromium.org/1312893006/diff/40001/Source/devtools/front_end/elements/ComputedStyleWidget.js#newcode160 Source/devtools/front_end/elements/ComputedStyleWidget.js:160: propertyElement.appendChild(createTextNode(": ")); createTextChild https://codereview.chromium.org/1312893006/diff/40001/Source/devtools/front_end/elements/ComputedStyleWidget.js#newcode162 Source/devtools/front_end/elements/ComputedStyleWidget.js:162: propertyElement.appendChild(createTextNode(";")); ditto
5 years, 3 months ago (2015-08-27 19:10:08 UTC) #2
lushnikov
brand new design: http://i.imgur.com/tQAywD2.png
5 years, 3 months ago (2015-08-28 01:34:45 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312893006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312893006/60001
5 years, 3 months ago (2015-08-28 01:36:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312893006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312893006/60001
5 years, 3 months ago (2015-08-28 01:38:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/104880)
5 years, 3 months ago (2015-08-28 02:34:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312893006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312893006/60001
5 years, 3 months ago (2015-08-28 06:30:50 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99945)
5 years, 3 months ago (2015-08-28 08:37:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312893006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312893006/60001
5 years, 3 months ago (2015-08-28 09:55:48 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 11:41:28 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201395

Powered by Google App Engine
This is Rietveld 408576698