DevTools: simplify WI.CSSProperty and WI.CSSStyleDeclaration interfaces

DevTools: simplify WI.CSSProperty and WI.CSSStyleDeclaration interfaces

This patch reduces interfaces of WI.CSSProperty and WI.CSSStyleDeclaration
classes.

The patch removes:
  - remove style.getLiveProperty() method and the whole notion of "live"
    properties
  - removes tripple state defined via property.active()/property.inactive()
    flags. (The state was tripple as !property.active() !== property.inactive()).
  - style.shorthandValue/style.shorthandIsImportant public methods
  - removes property.styleBased() property

The patch adds:
  - property.activeInStyle() method which defines if the current property
    has any effect in style.
  - style.leadingProperties() method which computes those properties
    which should be displayed in StylesSidebarPane.

BUG=496263
R=pfeldman
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201104

[lushnikov, 2015-08-21 03:52:08]

ptal!

[pfeldman, 2015-08-21 17:40:42]

https://codereview.chromium.org/1308663002/diff/1/LayoutTests/inspector/eleme...
File
LayoutTests/inspector/elements/styles-1/cssom-media-insert-crash-expected.txt
(right):

https://codereview.chromium.org/1308663002/diff/1/LayoutTests/inspector/eleme...
LayoutTests/inspector/elements/styles-1/cssom-media-insert-crash-expected.txt:9:
color: white;
Why was the order reversed?

https://codereview.chromium.org/1308663002/diff/1/LayoutTests/inspector/eleme...
File LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt
(right):

https://codereview.chromium.org/1308663002/diff/1/LayoutTests/inspector/eleme...
LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt:74: /--
overloaded --/     background: green;
You did not mention there was change in behavior

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/e...
File Source/devtools/front_end/elements/StylesSectionModel.js (right):

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/StylesSectionModel.js:331: if
(!property.activeInStyle())
Should you check for range here?

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/e...
File Source/devtools/front_end/elements/StylesSidebarPane.js (left):

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/StylesSidebarPane.js:1319: if
(style.getLiveProperty(shorthand)) {
Could you please split the move and the refactoring - it is hard to track it.

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/sdk/CSSStyleModel.js:1197: this._active = true;
Why is active default?

[lushnikov, 2015-08-21 21:25:03]

https://codereview.chromium.org/1308663002/diff/1/LayoutTests/inspector/eleme...
File
LayoutTests/inspector/elements/styles-1/cssom-media-insert-crash-expected.txt
(right):

https://codereview.chromium.org/1308663002/diff/1/LayoutTests/inspector/eleme...
LayoutTests/inspector/elements/styles-1/cssom-media-insert-crash-expected.txt:9:
color: white;
On 2015/08/21 17:40:42, pfeldman wrote:
> Why was the order reversed?

because background is a synthetically generated shorthand. It's a matter of
where we put it wrt other properties. There's no big difference.

https://codereview.chromium.org/1308663002/diff/1/LayoutTests/inspector/eleme...
File LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt
(right):

https://codereview.chromium.org/1308663002/diff/1/LayoutTests/inspector/eleme...
LayoutTests/inspector/elements/styles-2/inject-stylesheet-expected.txt:74: /--
overloaded --/     background: green;
On 2015/08/21 17:40:42, pfeldman wrote:
> You did not mention there was change in behavior

This actually fixes bug.

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/e...
File Source/devtools/front_end/elements/StylesSectionModel.js (right):

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/StylesSectionModel.js:331: if
(!property.activeInStyle())
On 2015/08/21 17:40:42, pfeldman wrote:
> Should you check for range here?

why should I?

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://codereview.chromium.org/1308663002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/sdk/CSSStyleModel.js:1197: this._active = true;
On 2015/08/21 17:40:42, pfeldman wrote:
> Why is active default?

We set all properties active by default, and then inactivate a handful of them.

[pfeldman, 2015-08-25 02:00:24]

lgtm

https://codereview.chromium.org/1308663002/diff/40001/Source/devtools/front_e...
File Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://codereview.chromium.org/1308663002/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/sdk/CSSStyleModel.js:756: return !!property.range;
This will always be this.range.

[lushnikov, 2015-08-25 02:01:01]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2015-08-25 02:01:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308663002/40001

[lushnikov, 2015-08-25 05:18:15]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2015-08-25 05:18:20]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2015-08-25 05:18:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308663002/40001

[commit-bot: I haz the power, 2015-08-25 05:22:59]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201104