Un-nest configs in GN files.

Un-nest configs in GN files.

People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.

Un-nest for clarity.

Re-land of http://crrev.com/1318823008 while preserving config ordering.

Committed: https://crrev.com/6dd952c77209619a445205998173fc40fb817be1
Cr-Commit-Position: refs/heads/master@{#346964}

[brettw, 2015-09-01 23:02:48]

brettw@chromium.org changed reviewers:
+ thakis@chromium.org

[brettw, 2015-09-01 23:02:52]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-01 23:03:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307223010/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307223010/40001

[commit-bot: I haz the power, 2015-09-01 23:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 23:41:31]

Dry run: This issue passed the CQ dry run.

[Nico, 2015-09-02 17:05:36]

lgtm, thanks!

I patched this in and verified that everything builds in a win/clang/gn build.

https://codereview.chromium.org/1307223010/diff/40001/third_party/libxml/BUIL...
File third_party/libxml/BUILD.gn (right):

https://codereview.chromium.org/1307223010/diff/40001/third_party/libxml/BUIL...
third_party/libxml/BUILD.gn:198: ]
(maybe this should move into the config too so that it has all the warning
flags?)

https://codereview.chromium.org/1307223010/diff/40001/third_party/sqlite/BUIL...
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/1307223010/diff/40001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:83: configs += [ ":sqlite_warnings" ]
you merged no_chromium_code and the :local_warnings blocks into a single block
(with a comment) in all other files, you probably want to do this here too

https://codereview.chromium.org/1307223010/diff/40001/third_party/usrsctp/BUI...
File third_party/usrsctp/BUILD.gn (right):

https://codereview.chromium.org/1307223010/diff/40001/third_party/usrsctp/BUI...
third_party/usrsctp/BUILD.gn:97:
"//build/config/compiler:no_incompatible_pointer_warnings",
(fwiw, this too must be after no_chromium_code. it happens to be after it in
lexicographic order, which i guess is why it doesn't have an explicit comment?)

[brettw, 2015-09-02 17:18:38]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-09-02 17:18:39]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1307223010/#ps80001
(title: "Review comments")

[commit-bot: I haz the power, 2015-09-02 17:19:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307223010/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307223010/80001

[commit-bot: I haz the power, 2015-09-02 17:57:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-02 17:58:05]

Patchset 5 (id:??) landed as
https://crrev.com/6dd952c77209619a445205998173fc40fb817be1
Cr-Commit-Position: refs/heads/master@{#346964}