Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: third_party/snappy/BUILD.gn

Issue 1307223010: Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/mesa/BUILD.gn ('k') | third_party/sqlite/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/snappy/BUILD.gn
diff --git a/third_party/snappy/BUILD.gn b/third_party/snappy/BUILD.gn
index 97cce89bc719d8425d88b54a724bb0d758027c81..7eabb7b19e9bff0edc44f35c9edbb833b6ffffd6 100644
--- a/third_party/snappy/BUILD.gn
+++ b/third_party/snappy/BUILD.gn
@@ -16,6 +16,14 @@ config("snappy_config") {
}
}
+config("snappy_warnings") {
+ if (is_clang) {
+ # ComputeTable is unused,
+ # https://code.google.com/p/snappy/issues/detail?id=96
+ cflags = [ "-Wno-unused-function" ]
+ }
+}
+
static_library("snappy") {
sources = [
"src/snappy-internal.h",
@@ -27,16 +35,13 @@ static_library("snappy") {
"src/snappy.h",
]
- config("snappy_warnings") {
- if (is_clang) {
- # ComputeTable is unused,
- # https://code.google.com/p/snappy/issues/detail?id=96
- cflags = [ "-Wno-unused-function" ]
- }
- }
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
- configs += [ ":snappy_warnings" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+
+ # Must be after no_chromium_code for warning flags to be ordered correctly.
+ ":snappy_warnings",
+ ]
public_configs = [ ":snappy_config" ]
if (is_win) {
« no previous file with comments | « third_party/mesa/BUILD.gn ('k') | third_party/sqlite/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698